implements PR016

This commit is contained in:
2026-03-24 13:42:21 +00:00
parent 8d8c3dc180
commit e4be2a033f
8 changed files with 437 additions and 69 deletions
@@ -125,4 +125,27 @@ class PbsParserStatementsTest {
assertTrue(diagnostics.hasErrors(), "Assignment target with call segment must be rejected");
}
@Test
void shouldParseThisAsAssignmentTargetRoot() {
final var source = """
declare struct Box(pub mut value: int) {
fn set(v: int) -> void {
this.value = v;
return;
}
}
""";
final var diagnostics = DiagnosticSink.empty();
final var fileId = new FileId(0);
final var ast = PbsParser.parse(PbsLexer.lex(source, fileId, diagnostics), fileId, diagnostics);
assertTrue(diagnostics.isEmpty(), "Assignment target rooted at 'this' should parse");
final var structDecl = assertInstanceOf(PbsAst.StructDecl.class, ast.topDecls().getFirst());
final var setMethod = structDecl.methods().getFirst();
final var assignment = assertInstanceOf(PbsAst.AssignStatement.class, setMethod.body().statements().getFirst());
assertEquals("this", assignment.target().rootName());
assertEquals(1, assignment.target().pathSegments().size());
}
}
@@ -0,0 +1,111 @@
package p.studio.compiler.pbs.semantics;
import org.junit.jupiter.api.Test;
import p.studio.compiler.pbs.PbsFrontendCompiler;
import p.studio.compiler.source.diagnostics.DiagnosticSink;
import p.studio.compiler.source.identifiers.FileId;
import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertFalse;
class PbsSemanticsAssignmentTest {
@Test
void shouldAllowLocalAndNestedFieldAssignments() {
final var source = """
declare struct Inner(pub mut value: int);
declare struct Outer(pub mut inner: Inner) {
fn reset(v: int) -> void {
this.inner.value = v;
return;
}
}
fn update(o: Outer, next: int) -> int {
let current: int = 0;
current = next;
o.inner.value = current;
return current;
}
""";
final var diagnostics = DiagnosticSink.empty();
new PbsFrontendCompiler().compileFile(new FileId(0), source, diagnostics);
assertFalse(diagnostics.stream().anyMatch(d ->
d.getCode().equals(PbsSemanticsErrors.E_SEM_ASSIGN_TARGET_UNRESOLVED.name())));
assertFalse(diagnostics.stream().anyMatch(d ->
d.getCode().equals(PbsSemanticsErrors.E_SEM_ASSIGN_TARGET_NOT_ASSIGNABLE.name())));
assertFalse(diagnostics.stream().anyMatch(d ->
d.getCode().equals(PbsSemanticsErrors.E_SEM_ASSIGN_TYPE_MISMATCH.name())));
assertFalse(diagnostics.stream().anyMatch(d ->
d.getCode().equals(PbsSemanticsErrors.E_SEM_FIELD_WRITE_ACCESS_DENIED.name())));
}
@Test
void shouldRejectUnresolvedImmutableAndTypeMismatchedAssignments() {
final var source = """
fn bad(v: int) -> int {
let const fixed: int = 1;
fixed = v;
missing = v;
let n: int = 0;
n = true;
return n;
}
""";
final var diagnostics = DiagnosticSink.empty();
new PbsFrontendCompiler().compileFile(new FileId(0), source, diagnostics);
final var unresolvedCount = diagnostics.stream()
.filter(d -> d.getCode().equals(PbsSemanticsErrors.E_SEM_ASSIGN_TARGET_UNRESOLVED.name()))
.count();
final var immutableCount = diagnostics.stream()
.filter(d -> d.getCode().equals(PbsSemanticsErrors.E_SEM_ASSIGN_TARGET_NOT_ASSIGNABLE.name()))
.count();
final var mismatchCount = diagnostics.stream()
.filter(d -> d.getCode().equals(PbsSemanticsErrors.E_SEM_ASSIGN_TYPE_MISMATCH.name()))
.count();
assertEquals(1, unresolvedCount);
assertEquals(1, immutableCount);
assertEquals(1, mismatchCount);
}
@Test
void shouldEnforceFieldReadAndWriteAccessRules() {
final var source = """
declare struct Data(pub mut open: int, pub ro: int, hidden: int) {
fn own(v: int) -> int {
this.hidden = v;
this.ro = v;
return this.hidden + this.ro + this.open;
}
}
fn outside(d: Data) -> int {
let a: int = d.open;
let b: int = d.ro;
let c: int = d.hidden;
d.open = 1;
d.ro = 2;
d.hidden = 3;
return a + b + c;
}
""";
final var diagnostics = DiagnosticSink.empty();
new PbsFrontendCompiler().compileFile(new FileId(0), source, diagnostics);
final var readDeniedCount = diagnostics.stream()
.filter(d -> d.getCode().equals(PbsSemanticsErrors.E_SEM_FIELD_READ_ACCESS_DENIED.name()))
.count();
final var writeDeniedCount = diagnostics.stream()
.filter(d -> d.getCode().equals(PbsSemanticsErrors.E_SEM_FIELD_WRITE_ACCESS_DENIED.name()))
.count();
assertEquals(1, readDeniedCount);
assertEquals(2, writeDeniedCount);
}
}