implements PR021
This commit is contained in:
+48
@@ -180,9 +180,57 @@ final class PbsFlowBodyAnalyzer {
|
||||
if (expression instanceof PbsAst.SwitchExpr switchExpr) {
|
||||
return switchAlwaysReturns(switchExpr, model);
|
||||
}
|
||||
if (expression instanceof PbsAst.HandleExpr handleExpr) {
|
||||
return handleAlwaysReturns(handleExpr, model);
|
||||
}
|
||||
return false;
|
||||
}
|
||||
|
||||
private boolean handleAlwaysReturns(
|
||||
final PbsAst.HandleExpr handleExpr,
|
||||
final Model model) {
|
||||
if (expressionAlwaysReturns(handleExpr.value(), model)) {
|
||||
return true;
|
||||
}
|
||||
if (handleExpr.arms().isEmpty()) {
|
||||
return false;
|
||||
}
|
||||
for (final var arm : handleExpr.arms()) {
|
||||
if (!handleArmAlwaysReturns(arm, model)) {
|
||||
return false;
|
||||
}
|
||||
}
|
||||
return true;
|
||||
}
|
||||
|
||||
private boolean handleArmAlwaysReturns(
|
||||
final PbsAst.HandleArm arm,
|
||||
final Model model) {
|
||||
if (arm.remapTarget() != null) {
|
||||
return true;
|
||||
}
|
||||
if (arm.block() == null) {
|
||||
return false;
|
||||
}
|
||||
final var terminal = unwrapGroup(arm.block().tailExpression());
|
||||
if (terminal instanceof PbsAst.ErrExpr errExpr) {
|
||||
return isKnownErrorPath(errExpr.errorPath(), model);
|
||||
}
|
||||
return false;
|
||||
}
|
||||
|
||||
private boolean isKnownErrorPath(
|
||||
final PbsAst.ErrorPath path,
|
||||
final Model model) {
|
||||
if (path == null || path.segments().size() != 2) {
|
||||
return false;
|
||||
}
|
||||
final var errorName = path.segments().getFirst();
|
||||
final var caseName = path.segments().get(1);
|
||||
final var errorCases = model.errors.get(errorName);
|
||||
return errorCases != null && errorCases.contains(caseName);
|
||||
}
|
||||
|
||||
private boolean switchAlwaysReturns(
|
||||
final PbsAst.SwitchExpr switchExpr,
|
||||
final Model model) {
|
||||
|
||||
Reference in New Issue
Block a user