implements PLN-0123

This commit is contained in:
2026-07-15 13:03:57 +01:00
parent f42c83bdca
commit cc4cb23b76
4 changed files with 37 additions and 3 deletions
@@ -120,6 +120,28 @@ class IRBackendExecutableContractTest {
"ReadOnlyList is audited as the ordered collection contract");
}
@Test
void publicIRBackendContractMustUseExplicitIdsOrStableKeysForKnownReferences() {
assertEquals(ModuleId.class, recordComponentType(IRBackendExecutableFunction.class, "moduleId"));
assertEquals(CallableId.class, recordComponentType(IRBackendExecutableFunction.class, "callableId"));
assertEquals(ModuleId.class, recordComponentType(IRBackendExecutableFunction.Instruction.class, "calleeModuleId"));
assertEquals(CallableId.class, recordComponentType(IRBackendExecutableFunction.Instruction.class, "calleeCallableId"));
assertEquals(IntrinsicId.class, recordComponentType(IRBackendExecutableFunction.IntrinsicCallMetadata.class, "intrinsicId"));
assertEquals(FileId.class, recordComponentType(IRBackendFile.class, "fileId"));
assertEquals(FileId.class, recordComponentType(IRFunction.class, "fileId"));
assertEquals(FileId.class, recordComponentType(IRGlobal.class, "fileId"));
assertEquals(ModuleId.class, recordComponentType(IRGlobal.class, "moduleId"));
assertEquals(FileId.class, recordComponentType(IRGlobalOrigin.class, "derivedFromFile"));
assertEquals(ModuleId.class, recordComponentType(IRGlobalOrigin.class, "derivedFromModule"));
assertEquals(FileId.class, recordComponentType(IRSyntheticOrigin.class, "fileId"));
assertEquals(ModuleId.class, recordComponentType(IRSyntheticFunction.class, "moduleId"));
assertEquals(String.class, recordComponentType(ModuleReference.class, "project"));
assertEquals(String.class, recordComponentType(CallableSignatureRef.class, "callableName"));
assertEquals(String.class, recordComponentType(IntrinsicReference.class, "canonicalName"));
}
@Test
void publicIRBackendContractMustNotExposePbsTypes() {
final var violations = new ArrayList<String>();
@@ -838,4 +860,16 @@ class IRBackendExecutableContractTest {
|| simpleName.endsWith("Visitor")
|| simpleName.endsWith("Provider");
}
private static Class<?> recordComponentType(
final Class<?> recordType,
final String componentName) {
for (final var component : recordType.getRecordComponents()) {
if (component.getName().equals(componentName)) {
return component.getType();
}
}
fail("missing record component " + recordType.getName() + "#" + componentName);
throw new IllegalStateException("unreachable");
}
}