implements PR-31 pack wizard validation snapshot gate

This commit is contained in:
2026-03-24 13:42:55 +00:00
parent 4fd956265f
commit 96643282af
2 changed files with 94 additions and 1 deletions
@@ -9,8 +9,10 @@ import p.packer.PackerWorkspaceService;
import p.packer.events.PackerEventKind;
import p.packer.events.PackerEventSink;
import p.packer.events.PackerProgress;
import p.packer.dtos.PackerDiagnosticDTO;
import p.packer.dtos.PackerPackSummaryAssetDTO;
import p.packer.dtos.PackerPackSummaryDTO;
import p.packer.dtos.PackerPackValidationAssetDTO;
import p.packer.messages.*;
import p.packer.messages.assets.*;
import p.packer.messages.diagnostics.PackerDiagnosticCategory;
@@ -158,7 +160,20 @@ public final class FileSystemPackerWorkspaceService implements PackerWorkspaceSe
@Override
public ValidatePackWorkspaceResult validatePackWorkspace(ValidatePackWorkspaceRequest request) {
throw new UnsupportedOperationException("pack workspace validation is not implemented yet");
final PackerProjectContext project = Objects.requireNonNull(request, "request").project();
final PackerRuntimeSnapshot snapshot = runtimeRegistry.getOrLoad(project).snapshot();
final List<PackerPackValidationAssetDTO> blockedAssets = snapshot.assets().stream()
.filter(runtimeAsset -> runtimeAsset.registryEntry().isPresent() && runtimeAsset.registryEntry().get().includedInBuild())
.map(this::toPackValidationAssetDTO)
.filter(PackerPackValidationAssetDTO::blocked)
.toList();
final PackerOperationStatus status = blockedAssets.isEmpty()
? PackerOperationStatus.SUCCESS
: PackerOperationStatus.PARTIAL;
final String summary = blockedAssets.isEmpty()
? "Pack validation completed without blocking diagnostics."
: "Pack validation found blocking diagnostics in " + blockedAssets.size() + " included assets.";
return new ValidatePackWorkspaceResult(status, summary, blockedAssets);
}
@Override
@@ -677,6 +692,29 @@ public final class FileSystemPackerWorkspaceService implements PackerWorkspaceSe
0L);
}
private PackerPackValidationAssetDTO toPackValidationAssetDTO(PackerRuntimeAsset runtimeAsset) {
final PackerRegistryEntry registryEntry = runtimeAsset.registryEntry()
.orElseThrow(() -> new IllegalArgumentException("pack validation asset must be registered"));
final PackerAssetDeclarationParseResult parsed = runtimeAsset.parsedDeclaration();
final PackerAssetDeclaration declaration = parsed.declaration();
final String assetName = declaration != null
? declaration.name()
: runtimeAsset.assetRoot().getFileName().toString();
final List<PackerDiagnostic> blockingDiagnostics = Stream.of(
parsed.diagnostics(),
runtimeAsset.walkDiagnostics(),
identityMismatchDiagnostics(registryEntry, parsed, runtimeAsset.manifestPath()))
.flatMap(Collection::stream)
.filter(PackerDiagnostic::blocking)
.toList();
return new PackerPackValidationAssetDTO(
registryEntry.assetId(),
assetName,
runtimeAsset.assetRoot(),
0L,
PackerReadMessageMapper.toDiagnosticDTOs(blockingDiagnostics));
}
private void saveRuntimeCache(PackerProjectContext project, PackerRuntimeSnapshot snapshot) {
cacheRepository.save(project, snapshot.cacheState());
}