implements PR-O2.2
This commit is contained in:
+80
@@ -0,0 +1,80 @@
|
||||
package p.studio.compiler.backend.bytecode;
|
||||
|
||||
import org.junit.jupiter.api.Test;
|
||||
import p.studio.utilities.structures.ReadOnlyList;
|
||||
|
||||
import java.nio.ByteBuffer;
|
||||
import java.nio.ByteOrder;
|
||||
|
||||
import static org.junit.jupiter.api.Assertions.assertDoesNotThrow;
|
||||
import static org.junit.jupiter.api.Assertions.assertEquals;
|
||||
import static org.junit.jupiter.api.Assertions.assertThrows;
|
||||
|
||||
class BytecodePreloadVerifierServiceTest {
|
||||
|
||||
private final BytecodePreloadVerifierService service = new BytecodePreloadVerifierService();
|
||||
|
||||
@Test
|
||||
void verifyMustAcceptTerminatedFunctionWithoutRawSyscall() {
|
||||
final var module = new BytecodeModule(
|
||||
0,
|
||||
ReadOnlyList.empty(),
|
||||
ReadOnlyList.from(new BytecodeModule.FunctionMeta(0, 2, 0, 0, 0, 1)),
|
||||
codeRet(),
|
||||
null,
|
||||
ReadOnlyList.empty(),
|
||||
ReadOnlyList.empty());
|
||||
|
||||
assertDoesNotThrow(() -> service.verify(module));
|
||||
}
|
||||
|
||||
@Test
|
||||
void verifyMustRejectRawSyscallInPreload() {
|
||||
final var module = new BytecodeModule(
|
||||
0,
|
||||
ReadOnlyList.empty(),
|
||||
ReadOnlyList.from(new BytecodeModule.FunctionMeta(0, 6, 0, 0, 0, 1)),
|
||||
codeRawSyscall(0x1001),
|
||||
null,
|
||||
ReadOnlyList.empty(),
|
||||
ReadOnlyList.empty());
|
||||
|
||||
final var thrown = assertThrows(BytecodeMarshalingException.class, () -> service.verify(module));
|
||||
assertEquals(BytecodeMarshalingErrorCode.MARSHAL_LINKAGE_RAW_SYSCALL_IN_PRELOAD, thrown.code());
|
||||
}
|
||||
|
||||
@Test
|
||||
void verifyMustRejectFunctionWithoutTerminator() {
|
||||
final var module = new BytecodeModule(
|
||||
0,
|
||||
ReadOnlyList.empty(),
|
||||
ReadOnlyList.from(new BytecodeModule.FunctionMeta(0, 6, 0, 0, 0, 1)),
|
||||
codeHostcall(0),
|
||||
null,
|
||||
ReadOnlyList.empty(),
|
||||
ReadOnlyList.from(new BytecodeModule.SyscallDecl("gfx", "draw", 1, 0, 0)));
|
||||
|
||||
final var thrown = assertThrows(BytecodeMarshalingException.class, () -> service.verify(module));
|
||||
assertEquals(BytecodeMarshalingErrorCode.MARSHAL_VERIFY_PRECHECK_UNTERMINATED_FUNCTION, thrown.code());
|
||||
}
|
||||
|
||||
private byte[] codeHostcall(final int index) {
|
||||
final var out = ByteBuffer.allocate(6).order(ByteOrder.LITTLE_ENDIAN);
|
||||
out.putShort((short) 0x71);
|
||||
out.putInt(index);
|
||||
return out.array();
|
||||
}
|
||||
|
||||
private byte[] codeRawSyscall(final int index) {
|
||||
final var out = ByteBuffer.allocate(6).order(ByteOrder.LITTLE_ENDIAN);
|
||||
out.putShort((short) 0x70);
|
||||
out.putInt(index);
|
||||
return out.array();
|
||||
}
|
||||
|
||||
private byte[] codeRet() {
|
||||
final var out = ByteBuffer.allocate(2).order(ByteOrder.LITTLE_ENDIAN);
|
||||
out.putShort((short) 0x51);
|
||||
return out.array();
|
||||
}
|
||||
}
|
||||
+3
-1
@@ -8,6 +8,7 @@ import p.studio.compiler.workspaces.stages.LoadSourcesPipelineStage;
|
||||
import p.studio.compiler.workspaces.stages.LowerToIRVMPipelineStage;
|
||||
import p.studio.compiler.workspaces.stages.OptimizeIRVMPipelineStage;
|
||||
import p.studio.compiler.workspaces.stages.ResolveDepsPipelineStage;
|
||||
import p.studio.compiler.workspaces.stages.VerifyBytecodePipelineStage;
|
||||
|
||||
import java.lang.reflect.Field;
|
||||
import java.util.List;
|
||||
@@ -33,7 +34,8 @@ class BuilderPipelineServiceOrderTest {
|
||||
LowerToIRVMPipelineStage.class,
|
||||
OptimizeIRVMPipelineStage.class,
|
||||
EmitBytecodePipelineStage.class,
|
||||
LinkBytecodePipelineStage.class),
|
||||
LinkBytecodePipelineStage.class,
|
||||
VerifyBytecodePipelineStage.class),
|
||||
stageTypes);
|
||||
}
|
||||
}
|
||||
|
||||
+56
@@ -0,0 +1,56 @@
|
||||
package p.studio.compiler.workspaces.stages;
|
||||
|
||||
import org.junit.jupiter.api.Test;
|
||||
import p.studio.compiler.backend.bytecode.BytecodeModule;
|
||||
import p.studio.compiler.messages.BuilderPipelineConfig;
|
||||
import p.studio.compiler.models.BuilderPipelineContext;
|
||||
import p.studio.utilities.logs.LogAggregator;
|
||||
import p.studio.utilities.structures.ReadOnlyList;
|
||||
|
||||
import java.nio.ByteBuffer;
|
||||
import java.nio.ByteOrder;
|
||||
|
||||
import static org.junit.jupiter.api.Assertions.assertEquals;
|
||||
import static org.junit.jupiter.api.Assertions.assertTrue;
|
||||
|
||||
class VerifyBytecodePipelineStageTest {
|
||||
|
||||
@Test
|
||||
void runMustFailWhenBytecodeModuleIsMissing() {
|
||||
final var ctx = BuilderPipelineContext.compilerContext(new BuilderPipelineConfig(false, "."));
|
||||
final var stage = new VerifyBytecodePipelineStage();
|
||||
|
||||
final var issues = stage.run(ctx, LogAggregator.empty());
|
||||
final var firstIssue = issues.asCollection().iterator().next();
|
||||
|
||||
assertTrue(issues.hasErrors());
|
||||
assertEquals("BACKEND_VERIFY_PRELOAD", firstIssue.getPhase());
|
||||
assertEquals("MARSHAL_FORMAT_STAGE_INPUT_MISSING", firstIssue.getCode());
|
||||
}
|
||||
|
||||
@Test
|
||||
void runMustRejectRawSyscallInPreload() {
|
||||
final var ctx = BuilderPipelineContext.compilerContext(new BuilderPipelineConfig(false, "."));
|
||||
ctx.bytecodeModule = new BytecodeModule(
|
||||
0,
|
||||
ReadOnlyList.empty(),
|
||||
ReadOnlyList.from(new BytecodeModule.FunctionMeta(0, 6, 0, 0, 0, 1)),
|
||||
codeRawSyscall(0x1001),
|
||||
null,
|
||||
ReadOnlyList.empty(),
|
||||
ReadOnlyList.empty());
|
||||
|
||||
final var issues = new VerifyBytecodePipelineStage().run(ctx, LogAggregator.empty());
|
||||
final var firstIssue = issues.asCollection().iterator().next();
|
||||
|
||||
assertTrue(issues.hasErrors());
|
||||
assertEquals("MARSHAL_LINKAGE_RAW_SYSCALL_IN_PRELOAD", firstIssue.getCode());
|
||||
}
|
||||
|
||||
private byte[] codeRawSyscall(final int index) {
|
||||
final var out = ByteBuffer.allocate(6).order(ByteOrder.LITTLE_ENDIAN);
|
||||
out.putShort((short) 0x70);
|
||||
out.putInt(index);
|
||||
return out.array();
|
||||
}
|
||||
}
|
||||
Reference in New Issue
Block a user