assets workspace agendas

This commit is contained in:
2026-03-24 13:42:40 +00:00
parent fcfe732eac
commit 3c5f949910
20 changed files with 919 additions and 444 deletions
@@ -0,0 +1,71 @@
# PR-05a Assets Workspace Foundation and Service State
## Briefing
Implement the first executable slice of the `Assets` workspace based on:
- [`../specs/4. Assets Workspace Specification.md`](../specs/4.%20Assets%20Workspace%20Specification.md)
This PR creates the workspace foundation, service-facing state model, and event wiring required by all later `Assets` workspace slices.
## Objective
Replace the current `WorkspaceId.ASSETS` placeholder with a concrete `AssetsWorkspace` foundation that can:
- boot inside the Studio shell,
- request and refresh asset data from Studio-facing services,
- maintain stable selection state,
- surface loading/empty/error states,
- and expose internal state in a way that later UI slices can reuse.
## Dependencies
- existing Studio shell and event bus foundations
- existing packer-facing Studio contracts and specifications
## Scope
- create a concrete `AssetsWorkspace`
- define workspace-local view state models for:
- navigator state
- selected asset state
- loading/error state
- define service-facing DTO adapters needed by the workspace
- define workspace event publications for asset refresh and selection updates
- integrate the workspace into the existing shell/workspace switch flow
## Non-Goals
- no final asset navigator visuals yet
- no final preview rendering yet
- no final staged mutation UI yet
- no production-grade packer backend implementation if stubs or adapters are still required
## Execution Method
1. Replace the placeholder assets workspace with a concrete class and root layout.
2. Introduce workspace-local state objects for navigator, selection, and detail hydration.
3. Introduce a Studio-facing service boundary for loading asset collections and selected-asset details.
4. Wire the workspace into `StudioWorkspaceEventBus` for refresh and selection lifecycle.
5. Define stable loading, empty, no-results, and error states in code.
## Acceptance Criteria
- selecting `Assets` opens a real workspace rather than a placeholder
- the workspace can request asset data through a Studio service boundary
- loading, empty, and error states are visible and distinct
- selection state is modelled explicitly and can be preserved by identity
- the workspace has enough state structure to support the later navigator and details PRs without redesign
## Validation
- unit tests for workspace state transitions
- unit tests for selection retention logic
- UI smoke validation that the Assets workspace mounts cleanly in the shell
## Affected Artifacts
- `prometeu-studio` workspace classes
- Studio event wiring
- Studio-facing asset service abstractions
- tests for workspace state and selection behavior
@@ -0,0 +1,72 @@
# PR-05b Asset Navigator Search Filters and Selection
## Briefing
Implement the left-side `Asset Tree` / `Asset Navigator` for the `Assets` workspace.
This PR applies the navigator and selection rules from:
- [`../specs/4. Assets Workspace Specification.md`](../specs/4.%20Assets%20Workspace%20Specification.md)
## Objective
Deliver the first concrete asset navigator with:
- asset-first grouped navigation
- semantic filters
- textual search
- stable single selection
- explicit loading/empty/no-results/error states
## Dependencies
- [`./PR-05a-assets-workspace-foundation-and-service-state.md`](./PR-05a-assets-workspace-foundation-and-service-state.md)
## Scope
- implement the custom visual asset navigator control
- render group nodes and asset nodes
- implement baseline filters:
- `Managed`
- `Orphan`
- `Diagnostics`
- `Preload`
- implement textual search over asset name and path context
- preserve selection by `asset_id` or orphan root path as appropriate
- allow optional expansion into asset inputs only as supporting inspection
## Non-Goals
- no final selected-asset details composition yet
- no final mutation staging UI yet
- no heavy sorting or multi-select support
## Execution Method
1. Implement the navigator control and node rendering model.
2. Add the baseline filters and search composition logic.
3. Add stable selection reconciliation during refresh.
4. Add explicit navigator states for loading, empty, no-results, and workspace error.
5. Add the visual markers for managed/orphan, diagnostics, preload, and broad asset family.
## Acceptance Criteria
- the `Assets` workspace shows a real asset navigator on the left
- assets are grouped by path-aware structure without degrading into a raw file tree
- filters and search work together
- selection remains stable across refresh when identity is preserved
- orphan assets appear in the same navigator flow with clearly differentiated styling
## Validation
- unit tests for filter/search composition
- unit tests for selection preservation rules
- UI smoke validation for node rendering and navigator states
## Affected Artifacts
- `AssetsWorkspace`
- custom navigator controls
- navigator view models
- selection reconciliation logic
- tests for filters, search, and selection behavior
@@ -0,0 +1,80 @@
# PR-05c Selected Asset Details Contract and Preview
## Briefing
Implement the selected-asset details surface in the required fixed order:
1. `Summary`
2. `Runtime Contract`
3. `Inputs / Preview`
4. `Diagnostics`
5. `Actions`
This PR materializes the didactic core of the `Assets` workspace.
## Objective
Deliver the first usable selected-asset details experience, including:
- summary identity/state rendering
- runtime-facing contract rendering
- inputs-by-role rendering
- first previewable input surfaces
- inline diagnostics
- action groups with routine vs sensitive separation
## Dependencies
- [`./PR-05a-assets-workspace-foundation-and-service-state.md`](./PR-05a-assets-workspace-foundation-and-service-state.md)
- [`./PR-05b-asset-navigator-search-filters-and-selection.md`](./PR-05b-asset-navigator-search-filters-and-selection.md)
## Scope
- render the fixed details skeleton
- render summary metadata and location
- render runtime contract fields such as `output.format`, `codec`, and `preload`
- render input groups and input selection
- implement first preview surfaces for previewable inputs
- render inline diagnostics by severity
- render action groups for:
- `Doctor`
- `Build`
- `Adopt`
- `Register`
- sensitive operations placeholders where needed
## Non-Goals
- no final staged preview/apply workflow yet
- no final lower log integration yet
- no exhaustive preview support for every asset family
## Execution Method
1. Build the selected-asset details layout in the mandated section order.
2. Render summary and runtime contract from workspace state.
3. Implement inputs-by-role rendering and input selection.
4. Implement baseline preview handling for previewable types.
5. Render inline diagnostics and action grouping.
## Acceptance Criteria
- selecting an asset hydrates a full details view in the fixed section order
- runtime-facing contract fields are visible without raw JSON inspection
- previewable inputs can be inspected from the details area
- diagnostics are visible inline and differentiated by severity
- routine actions and sensitive actions are visibly separated
## Validation
- unit tests for selected-asset detail mapping
- unit tests for action availability by asset state
- UI smoke validation for previewable input rendering
## Affected Artifacts
- `AssetsWorkspace` details area
- preview components
- diagnostics rendering
- action surface wiring
- tests for selected-asset detail behavior
@@ -0,0 +1,63 @@
# PR-05d Assets Activity Progress and Logs Integration
## Briefing
Integrate the `Assets` workspace with Studio activity, progress, and logs according to the assets workspace specification.
## Objective
Make the `Assets` workspace operationally legible by wiring:
- structured activity into the shell right-side panel
- contextual progress into the workspace
- detailed textual logs into the lower region
- failure retention and acknowledgement surfaces where required
## Dependencies
- [`./PR-05a-assets-workspace-foundation-and-service-state.md`](./PR-05a-assets-workspace-foundation-and-service-state.md)
- [`./PR-05c-selected-asset-details-contract-and-preview.md`](./PR-05c-selected-asset-details-contract-and-preview.md)
## Scope
- map asset-service events into Studio activity entries
- aggregate repetitive background events into user-facing summaries
- wire `progress_updated` into progress surfaces without feed spam
- expose lower-region textual logs for asset operations
- retain recent actionable failures until acknowledgement
- mirror selected-asset failures inline where applicable
## Non-Goals
- no generic all-workspace activity framework redesign beyond what Assets needs now
- no final cross-workspace logs unification
## Execution Method
1. Define asset-workspace activity mapping rules.
2. Wire workspace and global bus publications for asset activity.
3. Implement feed aggregation for repetitive events.
4. Implement inline progress and lower-region logs integration.
5. Retain and surface actionable failures across shell and workspace surfaces.
## Acceptance Criteria
- asset events appear in the global `Activity` feed as user-oriented entries
- progress updates do not spam the feed
- logs are visible in the lower region for technical drill-down
- actionable failures remain visible until acknowledged
- selected-asset failures also appear inline when relevant
## Validation
- unit tests for activity aggregation mapping
- unit tests for failure retention logic
- UI smoke validation for shell/workspace activity interplay
## Affected Artifacts
- activity event adapters
- progress surfaces
- workspace log region integration
- failure retention state
- tests for activity mapping and failure behavior
@@ -0,0 +1,75 @@
# PR-05e Assets Staged Mutations Preview and Apply
## Briefing
Implement the preview-first mutation flows for the `Assets` workspace.
This PR applies the staged mutation rules from:
- [`../specs/4. Assets Workspace Specification.md`](../specs/4.%20Assets%20Workspace%20Specification.md)
## Objective
Deliver inline staged mutation review for sensitive asset operations, including:
- preview generation
- blockers, warnings, and safe-fix separation
- registry vs workspace impact explanation
- apply gating
- activity integration for preview/apply lifecycle
## Dependencies
- [`./PR-05a-assets-workspace-foundation-and-service-state.md`](./PR-05a-assets-workspace-foundation-and-service-state.md)
- [`./PR-05c-selected-asset-details-contract-and-preview.md`](./PR-05c-selected-asset-details-contract-and-preview.md)
- [`./PR-05d-assets-activity-progress-and-logs-integration.md`](./PR-05d-assets-activity-progress-and-logs-integration.md)
## Scope
- implement inline staged review panel inside the `Assets` workspace
- support preview-first handling for:
- `Adopt`
- `Forget`
- `Remove`
- `Quarantine`
- relocational mutations
- batch mutations when available
- render proposed actions, blockers, warnings, safe fixes, and diff-style effects
- disable `Apply` while blockers exist
- use modal confirmation only for high-risk final commits
## Non-Goals
- no fully generic mutation framework for every Studio workspace
- no speculative batch authoring flows that do not yet exist in services
## Execution Method
1. Define the staged review panel and its state model.
2. Integrate preview requests and preview-ready responses from services.
3. Render registry impact and workspace impact separately.
4. Gate apply on blockers.
5. Wire `preview_ready`, `action_applied`, and `action_failed` into activity.
6. Add modal confirmation only where the final commit is high-risk.
## Acceptance Criteria
- sensitive asset mutations do not execute directly from a single click
- preview clearly shows what will change in registry and workspace
- blockers prevent apply
- safe fixes remain visually distinct from destructive actions
- preview/apply lifecycle events surface correctly in workspace and activity
## Validation
- unit tests for preview state mapping and apply gating
- unit tests for registry/workspace impact rendering rules
- UI smoke validation for staged mutation flows
## Affected Artifacts
- staged review panel
- asset mutation action wiring
- preview/apply state models
- activity integration for mutation lifecycle
- tests for preview and apply behavior
+9
View File
@@ -38,3 +38,12 @@ A Studio plan should usually include:
The current Studio execution queue is:
1. [`PR-05a-assets-workspace-foundation-and-service-state.md`](./PR-05a-assets-workspace-foundation-and-service-state.md)
2. [`PR-05b-asset-navigator-search-filters-and-selection.md`](./PR-05b-asset-navigator-search-filters-and-selection.md)
3. [`PR-05c-selected-asset-details-contract-and-preview.md`](./PR-05c-selected-asset-details-contract-and-preview.md)
4. [`PR-05d-assets-activity-progress-and-logs-integration.md`](./PR-05d-assets-activity-progress-and-logs-integration.md)
5. [`PR-05e-assets-staged-mutations-preview-and-apply.md`](./PR-05e-assets-staged-mutations-preview-and-apply.md)
Recommended execution order:
`PR-05a -> PR-05b -> PR-05c -> PR-05d -> PR-05e`