#![allow(clippy::collapsible_if)]
use crate::memory_banks::{GlyphBankPoolInstaller, SceneBankPoolInstaller, SoundBankPoolInstaller};
use prometeu_hal::AssetBridge;
use prometeu_hal::asset::{
    AssetCodec, AssetEntry, AssetId, AssetLoadError, AssetOpStatus, BankTelemetry, BankType,
    HandleId, LoadStatus, PreloadEntry, SCENE_DECODED_LAYER_OVERHEAD_BYTES_V1,
    SCENE_HEADER_BYTES_V1, SCENE_LAYER_COUNT_V1, SCENE_LAYER_HEADER_BYTES_V1,
    SCENE_PAYLOAD_MAGIC_V1, SCENE_PAYLOAD_VERSION_V1, SCENE_TILE_RECORD_BYTES_V1, SlotRef,
    SlotStats,
};
use prometeu_hal::cartridge::AssetsPayloadSource;
use prometeu_hal::color::Color;
use prometeu_hal::glyph::Glyph;
use prometeu_hal::glyph_bank::{GlyphBank, TileSize};
use prometeu_hal::sample::Sample;
use prometeu_hal::scene_bank::SceneBank;
use prometeu_hal::scene_layer::{ParallaxFactor, SceneLayer};
use prometeu_hal::sound_bank::SoundBank;
use prometeu_hal::tile::Tile;
use prometeu_hal::tilemap::TileMap;
use std::collections::HashMap;
use std::io::Read;
use std::sync::atomic::{AtomicUsize, Ordering};
use std::sync::{Arc, Mutex, RwLock};
use std::thread;
use std::time::Instant;

type ResidentMap<T> = HashMap<AssetId, ResidentEntry<T>>;
type StagedValue<T> = (Arc<T>, usize);
type StagingMap<T> = HashMap<HandleId, StagedValue<T>>;

type AssetTable = HashMap<AssetId, AssetEntry>;
type HandleTable = HashMap<HandleId, LoadHandleInfo>;

const GLYPH_BANK_PALETTE_COUNT_V1: usize = 64;
const GLYPH_BANK_COLORS_PER_PALETTE: usize = 16;
const GLYPH_BANK_PALETTE_BYTES_V1: usize =
    GLYPH_BANK_PALETTE_COUNT_V1 * GLYPH_BANK_COLORS_PER_PALETTE * size_of::<u16>();

/// Resident metadata for a decoded/materialized asset inside a BankPolicy.
#[derive(Debug)]
pub struct ResidentEntry<T> {
    /// The resident, materialized object.
    pub value: Arc<T>,

    /// Resident size in bytes (post-decode). Used for telemetry/budgets.
    pub bytes: usize,

    // /// Pin count (optional): if > 0, entry should not be evicted by policy.
    // pub pins: u32,
    /// Telemetry / profiling fields (optional but useful).
    pub loads: u64,
    pub last_used: Instant,
}

impl<T> ResidentEntry<T> {
    pub fn new(value: Arc<T>, bytes: usize) -> Self {
        Self {
            value,
            bytes,
            // pins: 0,
            loads: 1,
            last_used: Instant::now(),
        }
    }
}

/// Encapsulates the residency and staging policy for a specific type of asset.
/// This is internal to the AssetManager and not visible to peripherals.
pub struct BankPolicy<T> {
    /// Dedup table: asset_id -> resident entry (value + telemetry).
    pub resident: Arc<RwLock<ResidentMap<T>>>,

    /// Staging area: handle -> value ready to commit.
    pub staging: Arc<RwLock<StagingMap<T>>>,

    /// Total bytes currently in resident storage.
    pub used_bytes: Arc<AtomicUsize>,
    /// Bytes in staging awaiting commit.
    pub inflight_bytes: Arc<AtomicUsize>,
}

impl<T> Clone for BankPolicy<T> {
    fn clone(&self) -> Self {
        Self {
            resident: Arc::clone(&self.resident),
            staging: Arc::clone(&self.staging),
            used_bytes: Arc::clone(&self.used_bytes),
            inflight_bytes: Arc::clone(&self.inflight_bytes),
        }
    }
}

impl<T> BankPolicy<T> {
    pub fn new() -> Self {
        Self {
            resident: Arc::new(RwLock::new(HashMap::new())),
            staging: Arc::new(RwLock::new(HashMap::new())),
            used_bytes: Arc::new(AtomicUsize::new(0)),
            inflight_bytes: Arc::new(AtomicUsize::new(0)),
        }
    }

    /// Try get a resident value by asset_id (dedupe path).
    pub fn get_resident(&self, asset_id: AssetId) -> Option<Arc<T>> {
        let mut map = self.resident.write().unwrap();
        let entry = map.get_mut(&asset_id)?;
        entry.last_used = Instant::now();
        Some(Arc::clone(&entry.value))
    }

    /// Insert or reuse a resident entry. Returns the resident Arc<T>.
    pub fn put_resident(&self, asset_id: AssetId, value: Arc<T>, bytes: usize) -> Arc<T> {
        let mut map = self.resident.write().unwrap();
        match map.get_mut(&asset_id) {
            Some(existing) => {
                existing.last_used = Instant::now();
                existing.loads += 1;
                Arc::clone(&existing.value)
            }
            None => {
                let entry = ResidentEntry::new(Arc::clone(&value), bytes);
                map.insert(asset_id, entry);
                self.used_bytes.fetch_add(bytes, Ordering::Relaxed);
                value
            }
        }
    }

    /// Place a value into staging for a given handle.
    pub fn stage(&self, handle: HandleId, value: Arc<T>, bytes: usize) {
        self.staging.write().unwrap().insert(handle, (value, bytes));
        self.inflight_bytes.fetch_add(bytes, Ordering::Relaxed);
    }

    /// Take staged value (used by commit path).
    pub fn take_staging(&self, handle: HandleId) -> Option<StagedValue<T>> {
        let entry = self.staging.write().unwrap().remove(&handle);
        if let Some((_, bytes)) = entry.as_ref() {
            self.inflight_bytes.fetch_sub(*bytes, Ordering::Relaxed);
        }
        entry
    }

    pub fn clear(&self) {
        self.resident.write().unwrap().clear();
        self.staging.write().unwrap().clear();
        self.used_bytes.store(0, Ordering::Relaxed);
        self.inflight_bytes.store(0, Ordering::Relaxed);
    }
}

pub struct AssetManager {
    assets: Arc<RwLock<AssetTable>>,
    handles: Arc<RwLock<HandleTable>>,
    next_handle_id: Mutex<HandleId>,
    assets_data: Arc<RwLock<AssetsPayloadSource>>,

    /// Narrow hardware interfaces
    gfx_installer: Arc<dyn GlyphBankPoolInstaller>,
    sound_installer: Arc<dyn SoundBankPoolInstaller>,
    scene_installer: Arc<dyn SceneBankPoolInstaller>,

    /// Track what is installed in each hardware slot (for stats/info).
    gfx_slots: Arc<RwLock<[Option<AssetId>; 16]>>,
    sound_slots: Arc<RwLock<[Option<AssetId>; 16]>>,
    scene_slots: Arc<RwLock<[Option<AssetId>; 16]>>,

    /// Residency policy for GFX glyph banks.
    gfx_policy: BankPolicy<GlyphBank>,
    /// Residency policy for sound banks.
    sound_policy: BankPolicy<SoundBank>,
    /// Residency policy for scene banks.
    scene_policy: BankPolicy<SceneBank>,

    // Commits that are ready to be applied at the next frame boundary.
    pending_commits: Mutex<Vec<HandleId>>,
}

struct LoadHandleInfo {
    _asset_id: AssetId,
    slot: SlotRef,
    status: LoadStatus,
}

#[derive(Debug, Clone, Copy, PartialEq, Eq)]
enum AssetOpMode {
    DirectFromSlice,
    StageInMemory,
}

impl AssetBridge for AssetManager {
    fn initialize_for_cartridge(
        &self,
        assets: Vec<AssetEntry>,
        preload: Vec<PreloadEntry>,
        assets_data: AssetsPayloadSource,
    ) {
        self.initialize_for_cartridge(assets, preload, assets_data)
    }
    fn load(&self, asset_id: AssetId, slot_index: usize) -> Result<HandleId, AssetLoadError> {
        self.load(asset_id, slot_index)
    }
    fn status(&self, handle: HandleId) -> LoadStatus {
        self.status(handle)
    }
    fn commit(&self, handle: HandleId) -> AssetOpStatus {
        self.commit(handle)
    }
    fn cancel(&self, handle: HandleId) -> AssetOpStatus {
        self.cancel(handle)
    }
    fn apply_commits(&self) {
        self.apply_commits()
    }
    fn bank_telemetry(&self) -> Vec<BankTelemetry> {
        self.bank_telemetry()
    }
    fn slot_info(&self, slot: SlotRef) -> SlotStats {
        self.slot_info(slot)
    }
    fn shutdown(&self) {
        self.shutdown()
    }
}

impl AssetManager {
    fn decode_glyph_bank_layout(
        entry: &AssetEntry,
    ) -> Result<(TileSize, usize, usize, usize), String> {
        let meta = entry.metadata_as_glyph_bank()?;

        let tile_size = match meta.tile_size {
            8 => TileSize::Size8,
            16 => TileSize::Size16,
            32 => TileSize::Size32,
            _ => return Err(format!("Invalid tile_size: {}", meta.tile_size)),
        };

        if meta.palette_count as usize != GLYPH_BANK_PALETTE_COUNT_V1 {
            return Err(format!("Invalid palette_count: {}", meta.palette_count));
        }

        let width = meta.width as usize;
        let height = meta.height as usize;

        let logical_pixels = width.checked_mul(height).ok_or("GlyphBank dimensions overflow")?;
        let serialized_pixel_bytes = logical_pixels.div_ceil(2);
        let serialized_size = serialized_pixel_bytes
            .checked_add(GLYPH_BANK_PALETTE_BYTES_V1)
            .ok_or("GlyphBank serialized size overflow")?;
        let decoded_size = logical_pixels
            .checked_add(GLYPH_BANK_PALETTE_BYTES_V1)
            .ok_or("GlyphBank decoded size overflow")?;

        if entry.size != serialized_size as u64 {
            return Err(format!(
                "Invalid GLYPHBANK serialized size: expected {}, got {}",
                serialized_size, entry.size
            ));
        }

        if entry.decoded_size != decoded_size as u64 {
            return Err(format!(
                "Invalid GLYPHBANK decoded_size: expected {}, got {}",
                decoded_size, entry.decoded_size
            ));
        }

        Ok((tile_size, width, height, serialized_pixel_bytes))
    }

    fn unpack_glyph_bank_pixels(packed_pixels: &[u8], logical_pixels: usize) -> Vec<u8> {
        let mut pixel_indices = Vec::with_capacity(logical_pixels);
        for &packed in packed_pixels {
            if pixel_indices.len() < logical_pixels {
                pixel_indices.push(packed >> 4);
            }
            if pixel_indices.len() < logical_pixels {
                pixel_indices.push(packed & 0x0f);
            }
        }
        pixel_indices
    }

    fn op_mode_for(entry: &AssetEntry) -> Result<AssetOpMode, String> {
        match (entry.bank_type, entry.codec) {
            (BankType::GLYPH, AssetCodec::None) => Ok(AssetOpMode::StageInMemory),
            (BankType::SOUNDS, AssetCodec::None) => Ok(AssetOpMode::DirectFromSlice),
            (BankType::SCENE, AssetCodec::None) => Ok(AssetOpMode::DirectFromSlice),
        }
    }

    pub fn new(
        assets: Vec<AssetEntry>,
        assets_data: AssetsPayloadSource,
        gfx_installer: Arc<dyn GlyphBankPoolInstaller>,
        sound_installer: Arc<dyn SoundBankPoolInstaller>,
        scene_installer: Arc<dyn SceneBankPoolInstaller>,
    ) -> Self {
        let mut asset_map = HashMap::new();
        for entry in assets {
            asset_map.insert(entry.asset_id, entry);
        }

        Self {
            assets: Arc::new(RwLock::new(asset_map)),
            gfx_installer,
            sound_installer,
            scene_installer,
            gfx_slots: Arc::new(RwLock::new(std::array::from_fn(|_| None))),
            sound_slots: Arc::new(RwLock::new(std::array::from_fn(|_| None))),
            scene_slots: Arc::new(RwLock::new(std::array::from_fn(|_| None))),
            gfx_policy: BankPolicy::new(),
            sound_policy: BankPolicy::new(),
            scene_policy: BankPolicy::new(),
            handles: Arc::new(RwLock::new(HashMap::new())),
            next_handle_id: Mutex::new(1),
            assets_data: Arc::new(RwLock::new(assets_data)),
            pending_commits: Mutex::new(Vec::new()),
        }
    }

    pub fn initialize_for_cartridge(
        &self,
        assets: Vec<AssetEntry>,
        preload: Vec<PreloadEntry>,
        assets_data: AssetsPayloadSource,
    ) {
        self.shutdown();
        {
            let mut asset_map = self.assets.write().unwrap();
            asset_map.clear();
            for entry in assets.iter() {
                asset_map.insert(entry.asset_id, entry.clone());
            }
        }
        *self.assets_data.write().unwrap() = assets_data;

        // Perform Preload for assets in the preload list
        for item in preload {
            let entry_opt = {
                let assets = self.assets.read().unwrap();
                assets.get(&item.asset_id).cloned()
            };

            if let Some(entry) = entry_opt {
                let slot_index = item.slot;
                match entry.bank_type {
                    BankType::GLYPH => {
                        if let Ok(bank) =
                            Self::perform_load_glyph_bank(&entry, self.assets_data.clone())
                        {
                            let bank_arc = Arc::new(bank);
                            self.gfx_policy.put_resident(
                                entry.asset_id,
                                Arc::clone(&bank_arc),
                                entry.decoded_size as usize,
                            );
                            self.gfx_installer.install_glyph_bank(slot_index, bank_arc);
                            let mut slots = self.gfx_slots.write().unwrap();
                            if slot_index < slots.len() {
                                slots[slot_index] = Some(entry.asset_id);
                            }
                        }
                    }
                    BankType::SOUNDS => {
                        if let Ok(bank) =
                            Self::perform_load_sound_bank(&entry, self.assets_data.clone())
                        {
                            let bank_arc = Arc::new(bank);
                            self.sound_policy.put_resident(
                                entry.asset_id,
                                Arc::clone(&bank_arc),
                                entry.decoded_size as usize,
                            );
                            self.sound_installer.install_sound_bank(slot_index, bank_arc);
                            let mut slots = self.sound_slots.write().unwrap();
                            if slot_index < slots.len() {
                                slots[slot_index] = Some(entry.asset_id);
                            }
                        }
                    }
                    BankType::SCENE => {
                        if let Ok(bank) =
                            Self::perform_load_scene_bank(&entry, self.assets_data.clone())
                        {
                            let bank_arc = Arc::new(bank);
                            self.scene_policy.put_resident(
                                entry.asset_id,
                                Arc::clone(&bank_arc),
                                entry.decoded_size as usize,
                            );
                            self.scene_installer.install_scene_bank(slot_index, bank_arc);
                            let mut slots = self.scene_slots.write().unwrap();
                            if slot_index < slots.len() {
                                slots[slot_index] = Some(entry.asset_id);
                            }
                        }
                    }
                }
            }
        }
    }

    pub fn load(&self, asset_id: AssetId, slot_index: usize) -> Result<HandleId, AssetLoadError> {
        if slot_index >= 16 {
            return Err(AssetLoadError::SlotIndexInvalid);
        }
        let entry = {
            let assets = self.assets.read().unwrap();
            assets.get(&asset_id).ok_or(AssetLoadError::AssetNotFound)?.clone()
        };
        let slot = match entry.bank_type {
            BankType::GLYPH => SlotRef::gfx(slot_index),
            BankType::SOUNDS => SlotRef::audio(slot_index),
            BankType::SCENE => SlotRef::scene(slot_index),
        };

        let mut next_id = self.next_handle_id.lock().unwrap();
        let handle_id = *next_id;
        *next_id += 1;

        // Check if already resident (Dedup)
        let already_resident = match entry.bank_type {
            BankType::GLYPH => {
                if let Some(bank) = self.gfx_policy.get_resident(asset_id) {
                    self.gfx_policy.stage(handle_id, bank, entry.decoded_size as usize);
                    true
                } else {
                    false
                }
            }
            BankType::SOUNDS => {
                if let Some(bank) = self.sound_policy.get_resident(asset_id) {
                    self.sound_policy.stage(handle_id, bank, entry.decoded_size as usize);
                    true
                } else {
                    false
                }
            }
            BankType::SCENE => {
                if let Some(bank) = self.scene_policy.get_resident(asset_id) {
                    self.scene_policy.stage(handle_id, bank, entry.decoded_size as usize);
                    true
                } else {
                    false
                }
            }
        };

        if already_resident {
            self.handles.write().unwrap().insert(
                handle_id,
                LoadHandleInfo { _asset_id: asset_id, slot, status: LoadStatus::READY },
            );
            return Ok(handle_id);
        }

        // Not resident, start loading
        self.handles.write().unwrap().insert(
            handle_id,
            LoadHandleInfo { _asset_id: asset_id, slot, status: LoadStatus::PENDING },
        );

        let handles = self.handles.clone();
        let assets_data = self.assets_data.clone();
        let entry_clone = entry.clone();

        // Capture policies for the worker thread
        let gfx_policy = self.gfx_policy.clone();
        let sound_policy = self.sound_policy.clone();
        let scene_policy = self.scene_policy.clone();

        thread::spawn(move || {
            // Update status to LOADING
            {
                let mut handles_map = handles.write().unwrap();
                if let Some(h) = handles_map.get_mut(&handle_id) {
                    if h.status == LoadStatus::PENDING {
                        h.status = LoadStatus::LOADING;
                    } else {
                        return;
                    }
                } else {
                    return;
                }
            }

            match entry_clone.bank_type {
                BankType::GLYPH => {
                    let result = Self::perform_load_glyph_bank(&entry_clone, assets_data);
                    if let Ok(tilebank) = result {
                        let bank_arc = Arc::new(tilebank);
                        let resident_arc = gfx_policy.put_resident(
                            asset_id,
                            bank_arc,
                            entry_clone.decoded_size as usize,
                        );
                        gfx_policy.stage(
                            handle_id,
                            resident_arc,
                            entry_clone.decoded_size as usize,
                        );

                        let mut handles_map = handles.write().unwrap();
                        if let Some(h) = handles_map.get_mut(&handle_id) {
                            if h.status == LoadStatus::LOADING {
                                h.status = LoadStatus::READY;
                            }
                        }
                    } else {
                        let mut handles_map = handles.write().unwrap();
                        if let Some(h) = handles_map.get_mut(&handle_id) {
                            h.status = LoadStatus::ERROR;
                        }
                    }
                }
                BankType::SOUNDS => {
                    let result = Self::perform_load_sound_bank(&entry_clone, assets_data);
                    if let Ok(soundbank) = result {
                        let bank_arc = Arc::new(soundbank);
                        let resident_arc = sound_policy.put_resident(
                            asset_id,
                            bank_arc,
                            entry_clone.decoded_size as usize,
                        );
                        sound_policy.stage(
                            handle_id,
                            resident_arc,
                            entry_clone.decoded_size as usize,
                        );

                        let mut handles_map = handles.write().unwrap();
                        if let Some(h) = handles_map.get_mut(&handle_id) {
                            if h.status == LoadStatus::LOADING {
                                h.status = LoadStatus::READY;
                            }
                        }
                    } else {
                        let mut handles_map = handles.write().unwrap();
                        if let Some(h) = handles_map.get_mut(&handle_id) {
                            h.status = LoadStatus::ERROR;
                        }
                    }
                }
                BankType::SCENE => {
                    let result = Self::perform_load_scene_bank(&entry_clone, assets_data);
                    if let Ok(scenebank) = result {
                        let bank_arc = Arc::new(scenebank);
                        let resident_arc = scene_policy.put_resident(
                            asset_id,
                            bank_arc,
                            entry_clone.decoded_size as usize,
                        );
                        scene_policy.stage(
                            handle_id,
                            resident_arc,
                            entry_clone.decoded_size as usize,
                        );

                        let mut handles_map = handles.write().unwrap();
                        if let Some(h) = handles_map.get_mut(&handle_id) {
                            if h.status == LoadStatus::LOADING {
                                h.status = LoadStatus::READY;
                            }
                        }
                    } else {
                        let mut handles_map = handles.write().unwrap();
                        if let Some(h) = handles_map.get_mut(&handle_id) {
                            h.status = LoadStatus::ERROR;
                        }
                    }
                }
            }
        });

        Ok(handle_id)
    }

    fn perform_load_glyph_bank(
        entry: &AssetEntry,
        assets_data: Arc<RwLock<AssetsPayloadSource>>,
    ) -> Result<GlyphBank, String> {
        let op_mode = Self::op_mode_for(entry)?;
        let slice = {
            let assets_data = assets_data.read().unwrap();
            assets_data
                .open_slice(entry.offset, entry.size)
                .map_err(|_| "Asset offset/size out of bounds".to_string())?
        };

        match op_mode {
            AssetOpMode::StageInMemory => {
                let buffer =
                    slice.read_all().map_err(|_| "Asset payload read failed".to_string())?;
                Self::decode_glyph_bank_from_buffer(entry, &buffer)
            }
            AssetOpMode::DirectFromSlice => {
                let mut reader =
                    slice.open_reader().map_err(|_| "Asset payload read failed".to_string())?;
                Self::decode_glyph_bank_from_reader(entry, &mut reader)
            }
        }
    }

    fn decode_glyph_bank_from_buffer(
        entry: &AssetEntry,
        buffer: &[u8],
    ) -> Result<GlyphBank, String> {
        let (tile_size, width, height, packed_pixel_bytes) = Self::decode_glyph_bank_layout(entry)?;
        if buffer.len() < packed_pixel_bytes + GLYPH_BANK_PALETTE_BYTES_V1 {
            return Err("Buffer too small for GLYPHBANK".to_string());
        }

        let logical_pixels = width * height;
        let packed_pixels = &buffer[0..packed_pixel_bytes];
        let pixel_indices = Self::unpack_glyph_bank_pixels(packed_pixels, logical_pixels);
        let palette_data =
            &buffer[packed_pixel_bytes..packed_pixel_bytes + GLYPH_BANK_PALETTE_BYTES_V1];

        let mut palettes =
            [[Color::BLACK; GLYPH_BANK_COLORS_PER_PALETTE]; GLYPH_BANK_PALETTE_COUNT_V1];
        for (p, pal) in palettes.iter_mut().enumerate() {
            for (c, slot) in pal.iter_mut().enumerate() {
                let offset = (p * 16 + c) * 2;
                let color_raw =
                    u16::from_le_bytes([palette_data[offset], palette_data[offset + 1]]);
                *slot = Color(color_raw);
            }
        }

        Ok(GlyphBank { tile_size, width, height, pixel_indices, palettes })
    }

    fn decode_glyph_bank_from_reader(
        entry: &AssetEntry,
        reader: &mut impl Read,
    ) -> Result<GlyphBank, String> {
        let (tile_size, width, height, packed_pixel_bytes) = Self::decode_glyph_bank_layout(entry)?;
        let logical_pixels = width * height;
        let mut packed_pixels = vec![0_u8; packed_pixel_bytes];
        reader
            .read_exact(&mut packed_pixels)
            .map_err(|_| "Buffer too small for GLYPHBANK".to_string())?;

        let pixel_indices = Self::unpack_glyph_bank_pixels(&packed_pixels, logical_pixels);

        let mut palette_data = [0_u8; GLYPH_BANK_PALETTE_BYTES_V1];
        reader
            .read_exact(&mut palette_data)
            .map_err(|_| "Buffer too small for GLYPHBANK".to_string())?;

        let mut palettes =
            [[Color::BLACK; GLYPH_BANK_COLORS_PER_PALETTE]; GLYPH_BANK_PALETTE_COUNT_V1];
        for (p, pal) in palettes.iter_mut().enumerate() {
            for (c, slot) in pal.iter_mut().enumerate() {
                let offset = (p * 16 + c) * 2;
                let color_raw =
                    u16::from_le_bytes([palette_data[offset], palette_data[offset + 1]]);
                *slot = Color(color_raw);
            }
        }

        Ok(GlyphBank { tile_size, width, height, pixel_indices, palettes })
    }

    fn perform_load_sound_bank(
        entry: &AssetEntry,
        assets_data: Arc<RwLock<AssetsPayloadSource>>,
    ) -> Result<SoundBank, String> {
        let op_mode = Self::op_mode_for(entry)?;
        let slice = {
            let assets_data = assets_data.read().unwrap();
            assets_data
                .open_slice(entry.offset, entry.size)
                .map_err(|_| "Asset offset/size out of bounds".to_string())?
        };

        match op_mode {
            AssetOpMode::DirectFromSlice => {
                let mut reader =
                    slice.open_reader().map_err(|_| "Asset payload read failed".to_string())?;
                Self::decode_sound_bank_from_reader(entry, &mut reader)
            }
            AssetOpMode::StageInMemory => {
                let buffer =
                    slice.read_all().map_err(|_| "Asset payload read failed".to_string())?;
                Self::decode_sound_bank_from_buffer(entry, &buffer)
            }
        }
    }

    fn perform_load_scene_bank(
        entry: &AssetEntry,
        assets_data: Arc<RwLock<AssetsPayloadSource>>,
    ) -> Result<SceneBank, String> {
        let _ = entry.metadata_as_scene_bank()?;
        let op_mode = Self::op_mode_for(entry)?;
        let slice = {
            let assets_data = assets_data.read().unwrap();
            assets_data
                .open_slice(entry.offset, entry.size)
                .map_err(|_| "Asset offset/size out of bounds".to_string())?
        };

        match op_mode {
            AssetOpMode::DirectFromSlice => {
                let mut reader =
                    slice.open_reader().map_err(|_| "Asset payload read failed".to_string())?;
                Self::decode_scene_bank_from_reader(entry, &mut reader)
            }
            AssetOpMode::StageInMemory => {
                let buffer =
                    slice.read_all().map_err(|_| "Asset payload read failed".to_string())?;
                Self::decode_scene_bank_from_buffer(entry, &buffer)
            }
        }
    }

    fn decode_scene_bank_from_buffer(
        entry: &AssetEntry,
        buffer: &[u8],
    ) -> Result<SceneBank, String> {
        let _ = entry.metadata_as_scene_bank()?;

        if buffer.len() < SCENE_HEADER_BYTES_V1 {
            return Err("Buffer too small for SCENE".to_string());
        }

        if buffer[0..4] != SCENE_PAYLOAD_MAGIC_V1 {
            return Err("Invalid SCENE magic".to_string());
        }

        let version = u16::from_le_bytes([buffer[4], buffer[5]]);
        if version != SCENE_PAYLOAD_VERSION_V1 {
            return Err(format!("Unsupported SCENE version: {}", version));
        }

        let layer_count = u16::from_le_bytes([buffer[6], buffer[7]]) as usize;
        if layer_count != SCENE_LAYER_COUNT_V1 {
            return Err(format!("Invalid SCENE layer count: {}", layer_count));
        }

        let mut offset = SCENE_HEADER_BYTES_V1;
        let mut decoded_size = 0_usize;
        let layers = std::array::from_fn(|_| SceneLayer {
            active: false,
            glyph_bank_id: 0,
            tile_size: TileSize::Size8,
            parallax_factor: ParallaxFactor { x: 1.0, y: 1.0 },
            tilemap: TileMap { width: 0, height: 0, tiles: Vec::new() },
        });
        let mut layers = layers;

        for layer in &mut layers {
            let header_end = offset
                .checked_add(SCENE_LAYER_HEADER_BYTES_V1)
                .ok_or("SCENE layer header offset overflow")?;
            if header_end > buffer.len() {
                return Err("Buffer too small for SCENE layer header".to_string());
            }

            let flags = buffer[offset];
            let glyph_bank_id = buffer[offset + 1];
            let tile_size_raw = buffer[offset + 2];
            let tile_size = match tile_size_raw {
                8 => TileSize::Size8,
                16 => TileSize::Size16,
                32 => TileSize::Size32,
                other => return Err(format!("Invalid SCENE tile size: {}", other)),
            };
            let parallax_factor_x = f32::from_le_bytes([
                buffer[offset + 4],
                buffer[offset + 5],
                buffer[offset + 6],
                buffer[offset + 7],
            ]);
            let parallax_factor_y = f32::from_le_bytes([
                buffer[offset + 8],
                buffer[offset + 9],
                buffer[offset + 10],
                buffer[offset + 11],
            ]);
            if !parallax_factor_x.is_finite() || !parallax_factor_y.is_finite() {
                return Err("Invalid SCENE parallax_factor".to_string());
            }

            let width = u32::from_le_bytes([
                buffer[offset + 12],
                buffer[offset + 13],
                buffer[offset + 14],
                buffer[offset + 15],
            ]) as usize;
            let height = u32::from_le_bytes([
                buffer[offset + 16],
                buffer[offset + 17],
                buffer[offset + 18],
                buffer[offset + 19],
            ]) as usize;
            let tile_count = u32::from_le_bytes([
                buffer[offset + 20],
                buffer[offset + 21],
                buffer[offset + 22],
                buffer[offset + 23],
            ]) as usize;

            let expected_tile_count =
                width.checked_mul(height).ok_or("SCENE tile count overflow")?;
            if tile_count != expected_tile_count {
                return Err(format!(
                    "Invalid SCENE tile count for layer: expected {}, got {}",
                    expected_tile_count, tile_count
                ));
            }

            offset = header_end;

            let tile_bytes = tile_count
                .checked_mul(SCENE_TILE_RECORD_BYTES_V1)
                .ok_or("SCENE tile payload overflow")?;
            let tiles_end = offset.checked_add(tile_bytes).ok_or("SCENE payload overflow")?;
            if tiles_end > buffer.len() {
                return Err("Buffer too small for SCENE tile data".to_string());
            }

            let mut tiles = Vec::with_capacity(tile_count);
            for _ in 0..tile_count {
                let tile_flags = buffer[offset];
                let palette_id = buffer[offset + 1];
                let glyph_id = u16::from_le_bytes([buffer[offset + 2], buffer[offset + 3]]);
                tiles.push(Tile {
                    active: (tile_flags & 0b0000_0001) != 0,
                    glyph: Glyph { glyph_id, palette_id },
                    flip_x: (tile_flags & 0b0000_0010) != 0,
                    flip_y: (tile_flags & 0b0000_0100) != 0,
                });
                offset += SCENE_TILE_RECORD_BYTES_V1;
            }

            decoded_size = decoded_size
                .checked_add(SCENE_DECODED_LAYER_OVERHEAD_BYTES_V1)
                .and_then(|size| size.checked_add(tile_count * size_of::<Tile>()))
                .ok_or("SCENE decoded_size overflow")?;

            *layer = SceneLayer {
                active: (flags & 0b0000_0001) != 0,
                glyph_bank_id,
                tile_size,
                parallax_factor: ParallaxFactor { x: parallax_factor_x, y: parallax_factor_y },
                tilemap: TileMap { width, height, tiles },
            };
        }

        if offset != buffer.len() {
            return Err("Trailing bytes in SCENE payload".to_string());
        }

        if entry.decoded_size != decoded_size as u64 {
            return Err(format!(
                "Invalid SCENE decoded_size: expected {}, got {}",
                decoded_size, entry.decoded_size
            ));
        }

        Ok(SceneBank { layers })
    }

    fn decode_scene_bank_from_reader(
        entry: &AssetEntry,
        reader: &mut impl Read,
    ) -> Result<SceneBank, String> {
        let mut raw = Vec::new();
        reader.read_to_end(&mut raw).map_err(|_| "Asset payload read failed".to_string())?;
        Self::decode_scene_bank_from_buffer(entry, &raw)
    }

    fn decode_sound_bank_from_buffer(
        entry: &AssetEntry,
        buffer: &[u8],
    ) -> Result<SoundBank, String> {
        let meta = entry.metadata_as_sound_bank()?;
        let sample_rate = meta.sample_rate;

        let mut data = Vec::with_capacity(buffer.len() / 2);
        for i in (0..buffer.len()).step_by(2) {
            if i + 1 < buffer.len() {
                data.push(i16::from_le_bytes([buffer[i], buffer[i + 1]]));
            }
        }

        let sample = Arc::new(Sample::new(sample_rate, data));
        Ok(SoundBank::new(vec![sample]))
    }

    fn decode_sound_bank_from_reader(
        entry: &AssetEntry,
        reader: &mut impl Read,
    ) -> Result<SoundBank, String> {
        let mut raw = Vec::new();
        reader.read_to_end(&mut raw).map_err(|_| "Asset payload read failed".to_string())?;
        Self::decode_sound_bank_from_buffer(entry, &raw)
    }

    pub fn status(&self, handle: HandleId) -> LoadStatus {
        self.handles
            .read()
            .unwrap()
            .get(&handle)
            .map(|h| h.status)
            .unwrap_or(LoadStatus::UnknownHandle)
    }

    pub fn commit(&self, handle: HandleId) -> AssetOpStatus {
        let mut handles_map = self.handles.write().unwrap();
        let Some(h) = handles_map.get_mut(&handle) else {
            return AssetOpStatus::UnknownHandle;
        };
        if h.status == LoadStatus::READY {
            self.pending_commits.lock().unwrap().push(handle);
            AssetOpStatus::Ok
        } else {
            AssetOpStatus::InvalidState
        }
    }

    pub fn cancel(&self, handle: HandleId) -> AssetOpStatus {
        let mut final_status = AssetOpStatus::UnknownHandle;
        let mut handles_map = self.handles.write().unwrap();
        if let Some(h) = handles_map.get_mut(&handle) {
            final_status = match h.status {
                LoadStatus::PENDING | LoadStatus::LOADING | LoadStatus::READY => AssetOpStatus::Ok,
                LoadStatus::CANCELED => AssetOpStatus::Ok,
                _ => AssetOpStatus::InvalidState,
            };
            match h.status {
                LoadStatus::PENDING | LoadStatus::LOADING | LoadStatus::READY => {
                    h.status = LoadStatus::CANCELED;
                }
                _ => {}
            }
        }
        self.gfx_policy.take_staging(handle);
        self.sound_policy.take_staging(handle);
        self.scene_policy.take_staging(handle);
        final_status
    }

    pub fn apply_commits(&self) {
        let mut pending = self.pending_commits.lock().unwrap();
        let mut handles = self.handles.write().unwrap();

        for handle_id in pending.drain(..) {
            if let Some(h) = handles.get_mut(&handle_id) {
                if h.status == LoadStatus::READY {
                    match h.slot.asset_type {
                        BankType::GLYPH => {
                            if let Some((bank, _)) = self.gfx_policy.take_staging(handle_id) {
                                self.gfx_installer.install_glyph_bank(h.slot.index, bank);
                                let mut slots = self.gfx_slots.write().unwrap();
                                if h.slot.index < slots.len() {
                                    slots[h.slot.index] = Some(h._asset_id);
                                }
                                h.status = LoadStatus::COMMITTED;
                            }
                        }
                        BankType::SOUNDS => {
                            if let Some((bank, _)) = self.sound_policy.take_staging(handle_id) {
                                self.sound_installer.install_sound_bank(h.slot.index, bank);
                                let mut slots = self.sound_slots.write().unwrap();
                                if h.slot.index < slots.len() {
                                    slots[h.slot.index] = Some(h._asset_id);
                                }
                                h.status = LoadStatus::COMMITTED;
                            }
                        }
                        BankType::SCENE => {
                            if let Some((bank, _)) = self.scene_policy.take_staging(handle_id) {
                                self.scene_installer.install_scene_bank(h.slot.index, bank);
                                let mut slots = self.scene_slots.write().unwrap();
                                if h.slot.index < slots.len() {
                                    slots[h.slot.index] = Some(h._asset_id);
                                }
                                h.status = LoadStatus::COMMITTED;
                            }
                        }
                    }
                }
            }
        }
    }

    pub fn bank_telemetry(&self) -> Vec<BankTelemetry> {
        vec![
            self.bank_telemetry_for(BankType::GLYPH),
            self.bank_telemetry_for(BankType::SOUNDS),
            self.bank_telemetry_for(BankType::SCENE),
        ]
    }

    fn bank_telemetry_for(&self, kind: BankType) -> BankTelemetry {
        let used_slots = match kind {
            BankType::GLYPH => {
                self.gfx_slots.read().unwrap().iter().filter(|slot| slot.is_some()).count()
            }
            BankType::SOUNDS => {
                self.sound_slots.read().unwrap().iter().filter(|slot| slot.is_some()).count()
            }
            BankType::SCENE => {
                self.scene_slots.read().unwrap().iter().filter(|slot| slot.is_some()).count()
            }
        };

        BankTelemetry { bank_type: kind, used_slots, total_slots: 16 }
    }

    pub fn slot_info(&self, slot: SlotRef) -> SlotStats {
        match slot.asset_type {
            BankType::GLYPH => {
                let slots = self.gfx_slots.read().unwrap();
                let asset_id = slots.get(slot.index).and_then(|s| *s);

                let (bytes, asset_name) = if let Some(id) = &asset_id {
                    let bytes = self
                        .gfx_policy
                        .resident
                        .read()
                        .unwrap()
                        .get(id)
                        .map(|entry| entry.bytes)
                        .unwrap_or(0);
                    let name = self.assets.read().unwrap().get(id).map(|e| e.asset_name.clone());
                    (bytes, name)
                } else {
                    (0, None)
                };

                SlotStats { asset_id, asset_name, generation: 0, resident_bytes: bytes }
            }
            BankType::SOUNDS => {
                let slots = self.sound_slots.read().unwrap();
                let asset_id = slots.get(slot.index).and_then(|s| *s);

                let (bytes, asset_name) = if let Some(id) = &asset_id {
                    let bytes = self
                        .sound_policy
                        .resident
                        .read()
                        .unwrap()
                        .get(id)
                        .map(|entry| entry.bytes)
                        .unwrap_or(0);
                    let name = self.assets.read().unwrap().get(id).map(|e| e.asset_name.clone());
                    (bytes, name)
                } else {
                    (0, None)
                };

                SlotStats { asset_id, asset_name, generation: 0, resident_bytes: bytes }
            }
            BankType::SCENE => {
                let slots = self.scene_slots.read().unwrap();
                let asset_id = slots.get(slot.index).and_then(|s| *s);

                let (bytes, asset_name) = if let Some(id) = &asset_id {
                    let bytes = self
                        .scene_policy
                        .resident
                        .read()
                        .unwrap()
                        .get(id)
                        .map(|entry| entry.bytes)
                        .unwrap_or(0);
                    let name = self.assets.read().unwrap().get(id).map(|e| e.asset_name.clone());
                    (bytes, name)
                } else {
                    (0, None)
                };

                SlotStats { asset_id, asset_name, generation: 0, resident_bytes: bytes }
            }
        }
    }

    pub fn shutdown(&self) {
        self.gfx_policy.clear();
        self.sound_policy.clear();
        self.scene_policy.clear();
        self.handles.write().unwrap().clear();
        self.pending_commits.lock().unwrap().clear();
        self.gfx_slots.write().unwrap().fill(None);
        self.sound_slots.write().unwrap().fill(None);
        self.scene_slots.write().unwrap().fill(None);
    }
}

#[cfg(test)]
mod tests {
    use super::*;
    use crate::memory_banks::{
        GlyphBankPoolAccess, MemoryBanks, SceneBankPoolAccess, SoundBankPoolAccess,
    };
    use prometeu_hal::asset::{
        AssetCodec, SCENE_DECODED_LAYER_OVERHEAD_BYTES_V1, SCENE_LAYER_COUNT_V1,
        SCENE_PAYLOAD_MAGIC_V1, SCENE_PAYLOAD_VERSION_V1,
    };
    use prometeu_hal::glyph::Glyph;
    use prometeu_hal::scene_layer::{ParallaxFactor, SceneLayer};
    use prometeu_hal::tile::Tile;
    use prometeu_hal::tilemap::TileMap;

    fn expected_glyph_payload_size(width: usize, height: usize) -> usize {
        (width * height).div_ceil(2) + GLYPH_BANK_PALETTE_BYTES_V1
    }

    fn expected_glyph_decoded_size(width: usize, height: usize) -> usize {
        width * height + GLYPH_BANK_PALETTE_BYTES_V1
    }

    fn test_glyph_asset_data() -> Vec<u8> {
        let mut data = vec![0x11u8; 128];
        data.extend_from_slice(&[0u8; GLYPH_BANK_PALETTE_BYTES_V1]);
        data
    }

    fn test_glyph_asset_entry(asset_name: &str, width: usize, height: usize) -> AssetEntry {
        AssetEntry {
            asset_id: 0,
            asset_name: asset_name.to_string(),
            bank_type: BankType::GLYPH,
            offset: 0,
            size: expected_glyph_payload_size(width, height) as u64,
            decoded_size: expected_glyph_decoded_size(width, height) as u64,
            codec: AssetCodec::None,
            metadata: serde_json::json!({
                "tile_size": 16,
                "width": width,
                "height": height,
                "palette_count": GLYPH_BANK_PALETTE_COUNT_V1,
                "palette_authored": GLYPH_BANK_PALETTE_COUNT_V1
            }),
        }
    }

    fn test_scene() -> SceneBank {
        let make_layer =
            |glyph_bank_id: u8, parallax_x: f32, parallax_y: f32, tile_size: TileSize| SceneLayer {
                active: glyph_bank_id != 3,
                glyph_bank_id,
                tile_size,
                parallax_factor: ParallaxFactor { x: parallax_x, y: parallax_y },
                tilemap: TileMap {
                    width: 2,
                    height: 2,
                    tiles: vec![
                        Tile {
                            active: true,
                            glyph: Glyph {
                                glyph_id: 10 + glyph_bank_id as u16,
                                palette_id: glyph_bank_id,
                            },
                            flip_x: false,
                            flip_y: false,
                        },
                        Tile {
                            active: true,
                            glyph: Glyph {
                                glyph_id: 20 + glyph_bank_id as u16,
                                palette_id: glyph_bank_id + 1,
                            },
                            flip_x: true,
                            flip_y: false,
                        },
                        Tile {
                            active: true,
                            glyph: Glyph {
                                glyph_id: 30 + glyph_bank_id as u16,
                                palette_id: glyph_bank_id + 2,
                            },
                            flip_x: false,
                            flip_y: true,
                        },
                        Tile {
                            active: glyph_bank_id != 2,
                            glyph: Glyph {
                                glyph_id: 40 + glyph_bank_id as u16,
                                palette_id: glyph_bank_id + 3,
                            },
                            flip_x: true,
                            flip_y: true,
                        },
                    ],
                },
            };

        SceneBank {
            layers: [
                make_layer(0, 1.0, 1.0, TileSize::Size16),
                make_layer(1, 0.5, 0.75, TileSize::Size8),
                make_layer(2, 1.0, 0.5, TileSize::Size32),
                make_layer(3, 0.25, 0.25, TileSize::Size16),
            ],
        }
    }

    fn expected_scene_decoded_size(scene: &SceneBank) -> usize {
        scene
            .layers
            .iter()
            .map(|layer| {
                SCENE_DECODED_LAYER_OVERHEAD_BYTES_V1
                    + layer.tilemap.tiles.len() * size_of::<Tile>()
            })
            .sum()
    }

    fn encode_scene_payload(scene: &SceneBank) -> Vec<u8> {
        let mut data = Vec::new();
        data.extend_from_slice(&SCENE_PAYLOAD_MAGIC_V1);
        data.extend_from_slice(&SCENE_PAYLOAD_VERSION_V1.to_le_bytes());
        data.extend_from_slice(&(SCENE_LAYER_COUNT_V1 as u16).to_le_bytes());
        data.extend_from_slice(&0_u32.to_le_bytes());

        for layer in &scene.layers {
            let layer_flags = if layer.active { 0b0000_0001 } else { 0 };
            data.push(layer_flags);
            data.push(layer.glyph_bank_id);
            data.push(layer.tile_size as u8);
            data.push(0);
            data.extend_from_slice(&layer.parallax_factor.x.to_le_bytes());
            data.extend_from_slice(&layer.parallax_factor.y.to_le_bytes());
            data.extend_from_slice(&(layer.tilemap.width as u32).to_le_bytes());
            data.extend_from_slice(&(layer.tilemap.height as u32).to_le_bytes());
            data.extend_from_slice(&(layer.tilemap.tiles.len() as u32).to_le_bytes());
            data.extend_from_slice(&0_u32.to_le_bytes());

            for tile in &layer.tilemap.tiles {
                let mut tile_flags = 0_u8;
                if tile.active {
                    tile_flags |= 0b0000_0001;
                }
                if tile.flip_x {
                    tile_flags |= 0b0000_0010;
                }
                if tile.flip_y {
                    tile_flags |= 0b0000_0100;
                }
                data.push(tile_flags);
                data.push(tile.glyph.palette_id);
                data.extend_from_slice(&tile.glyph.glyph_id.to_le_bytes());
            }
        }

        data
    }

    fn test_scene_asset_entry(asset_name: &str, data: &[u8], scene: &SceneBank) -> AssetEntry {
        AssetEntry {
            asset_id: 2,
            asset_name: asset_name.to_string(),
            bank_type: BankType::SCENE,
            offset: 0,
            size: data.len() as u64,
            decoded_size: expected_scene_decoded_size(scene) as u64,
            codec: AssetCodec::None,
            metadata: serde_json::json!({}),
        }
    }

    #[test]
    fn test_decode_glyph_bank_unpacks_packed_pixels_and_reads_palette_colors() {
        let entry = test_glyph_asset_entry("glyphs", 2, 2);
        let mut data = vec![0x10, 0x23];
        data.extend_from_slice(&[0u8; GLYPH_BANK_PALETTE_BYTES_V1]);
        data[2] = 0x34;
        data[3] = 0x12;

        let bank =
            AssetManager::decode_glyph_bank_from_buffer(&entry, &data).expect("glyph decode");

        assert_eq!(bank.pixel_indices, vec![1, 0, 2, 3]);
        assert_eq!(bank.palettes[0][0], Color(0x1234));
    }

    #[test]
    fn test_decode_glyph_bank_rejects_short_packed_buffer() {
        let entry = test_glyph_asset_entry("glyphs", 16, 16);
        let data = vec![0u8; expected_glyph_payload_size(16, 16) - 1];

        let err = match AssetManager::decode_glyph_bank_from_buffer(&entry, &data) {
            Ok(_) => panic!("glyph decode should reject short buffer"),
            Err(err) => err,
        };

        assert_eq!(err, "Buffer too small for GLYPHBANK");
    }

    #[test]
    fn test_decode_glyph_bank_requires_palette_count_64() {
        let mut entry = test_glyph_asset_entry("glyphs", 16, 16);
        entry.metadata["palette_count"] = serde_json::json!(32);

        let err =
            match AssetManager::decode_glyph_bank_from_buffer(&entry, &test_glyph_asset_data()) {
                Ok(_) => panic!("glyph decode should reject invalid palette_count"),
                Err(err) => err,
            };

        assert_eq!(err, "Invalid palette_count: 32");
    }

    #[test]
    fn test_op_mode_for_glyphs_none_stages_in_memory() {
        let entry = test_glyph_asset_entry("glyphs", 16, 16);

        assert_eq!(AssetManager::op_mode_for(&entry), Ok(AssetOpMode::StageInMemory));
    }

    #[test]
    fn test_op_mode_for_glyphs_none_uses_typed_codec() {
        let entry = test_glyph_asset_entry("glyphs", 16, 16);
        assert_eq!(AssetManager::op_mode_for(&entry), Ok(AssetOpMode::StageInMemory));
    }

    #[test]
    fn test_op_mode_for_sounds_none_reads_direct_from_slice() {
        let entry = AssetEntry {
            asset_id: 1,
            asset_name: "sound".to_string(),
            bank_type: BankType::SOUNDS,
            offset: 0,
            size: 8,
            decoded_size: 8,
            codec: AssetCodec::None,
            metadata: serde_json::json!({
                "sample_rate": 44100,
                "channels": 1
            }),
        };

        assert_eq!(AssetManager::op_mode_for(&entry), Ok(AssetOpMode::DirectFromSlice));
    }

    #[test]
    fn test_op_mode_for_scene_none_reads_direct_from_slice() {
        let scene = test_scene();
        let data = encode_scene_payload(&scene);
        let entry = test_scene_asset_entry("scene", &data, &scene);

        assert_eq!(AssetManager::op_mode_for(&entry), Ok(AssetOpMode::DirectFromSlice));
    }

    #[test]
    fn test_decode_scene_bank_from_binary_payload() {
        let scene = test_scene();
        let data = encode_scene_payload(&scene);
        let entry = test_scene_asset_entry("scene", &data, &scene);

        let decoded = AssetManager::decode_scene_bank_from_buffer(&entry, &data).expect("scene");

        assert_eq!(decoded.layers[1].glyph_bank_id, 1);
        assert_eq!(decoded.layers[1].parallax_factor.x, 0.5);
        assert_eq!(decoded.layers[2].tile_size, TileSize::Size32);
        assert_eq!(decoded.layers[0].tilemap.tiles[1].flip_x, true);
        assert_eq!(decoded.layers[2].tilemap.tiles[2].flip_y, true);
        assert_eq!(decoded.layers[3].active, false);
    }

    #[test]
    fn test_decode_scene_bank_rejects_invalid_version() {
        let scene = test_scene();
        let mut data = encode_scene_payload(&scene);
        data[4..6].copy_from_slice(&2_u16.to_le_bytes());
        let entry = test_scene_asset_entry("scene", &data, &scene);

        let err = AssetManager::decode_scene_bank_from_buffer(&entry, &data).unwrap_err();

        assert_eq!(err, "Unsupported SCENE version: 2");
    }

    #[test]
    fn test_decode_scene_bank_rejects_invalid_tile_size() {
        let scene = test_scene();
        let mut data = encode_scene_payload(&scene);
        data[14] = 12;
        let entry = test_scene_asset_entry("scene", &data, &scene);

        let err = AssetManager::decode_scene_bank_from_buffer(&entry, &data).unwrap_err();

        assert_eq!(err, "Invalid SCENE tile size: 12");
    }

    #[test]
    fn test_decode_scene_bank_rejects_layer_count_mismatch() {
        let scene = test_scene();
        let mut data = encode_scene_payload(&scene);
        data[6..8].copy_from_slice(&3_u16.to_le_bytes());
        let entry = test_scene_asset_entry("scene", &data, &scene);

        let err = AssetManager::decode_scene_bank_from_buffer(&entry, &data).unwrap_err();

        assert_eq!(err, "Invalid SCENE layer count: 3");
    }

    #[test]
    fn test_decode_scene_bank_rejects_tile_count_mismatch() {
        let scene = test_scene();
        let mut data = encode_scene_payload(&scene);
        data[32..36].copy_from_slice(&5_u32.to_le_bytes());
        let entry = test_scene_asset_entry("scene", &data, &scene);

        let err = AssetManager::decode_scene_bank_from_buffer(&entry, &data).unwrap_err();

        assert_eq!(err, "Invalid SCENE tile count for layer: expected 4, got 5");
    }

    #[test]
    fn test_asset_loading_flow() {
        let banks = Arc::new(MemoryBanks::new());
        let gfx_installer = Arc::clone(&banks) as Arc<dyn GlyphBankPoolInstaller>;
        let sound_installer = Arc::clone(&banks) as Arc<dyn SoundBankPoolInstaller>;
        let scene_installer = Arc::clone(&banks) as Arc<dyn SceneBankPoolInstaller>;

        let data = test_glyph_asset_data();
        let asset_entry = test_glyph_asset_entry("test_glyphs", 16, 16);

        let am = AssetManager::new(
            vec![asset_entry],
            AssetsPayloadSource::from_bytes(data),
            gfx_installer,
            sound_installer,
            scene_installer,
        );
        let handle = am.load(0, 0).expect("Should start loading");

        let mut status = am.status(handle);
        let start = Instant::now();
        while status != LoadStatus::READY && start.elapsed().as_secs() < 5 {
            thread::sleep(std::time::Duration::from_millis(10));
            status = am.status(handle);
        }

        assert_eq!(status, LoadStatus::READY);

        {
            let staging = am.gfx_policy.staging.read().unwrap();
            assert!(staging.contains_key(&handle));
        }

        am.commit(handle);
        am.apply_commits();

        assert_eq!(am.status(handle), LoadStatus::COMMITTED);
        assert!(banks.glyph_bank_slot(0).is_some());
    }

    #[test]
    fn test_asset_dedup() {
        let banks = Arc::new(MemoryBanks::new());
        let gfx_installer = Arc::clone(&banks) as Arc<dyn GlyphBankPoolInstaller>;
        let sound_installer = Arc::clone(&banks) as Arc<dyn SoundBankPoolInstaller>;
        let scene_installer = Arc::clone(&banks) as Arc<dyn SceneBankPoolInstaller>;

        let data = test_glyph_asset_data();
        let asset_entry = test_glyph_asset_entry("test_glyphs", 16, 16);

        let am = AssetManager::new(
            vec![asset_entry],
            AssetsPayloadSource::from_bytes(data),
            gfx_installer,
            sound_installer,
            scene_installer,
        );

        let handle1 = am.load(0, 0).unwrap();
        let start = Instant::now();
        while am.status(handle1) != LoadStatus::READY && start.elapsed().as_secs() < 5 {
            thread::sleep(std::time::Duration::from_millis(10));
        }

        let handle2 = am.load(0, 1).unwrap();
        assert_eq!(am.status(handle2), LoadStatus::READY);

        let staging = am.gfx_policy.staging.read().unwrap();
        let bank1 = &staging.get(&handle1).unwrap().0;
        let bank2 = &staging.get(&handle2).unwrap().0;
        assert!(Arc::ptr_eq(bank1, bank2));
    }

    #[test]
    fn test_sound_asset_loading() {
        let banks = Arc::new(MemoryBanks::new());
        let gfx_installer = Arc::clone(&banks) as Arc<dyn GlyphBankPoolInstaller>;
        let sound_installer = Arc::clone(&banks) as Arc<dyn SoundBankPoolInstaller>;
        let scene_installer = Arc::clone(&banks) as Arc<dyn SceneBankPoolInstaller>;

        // 100 samples of 16-bit PCM (zeros)
        let data = vec![0u8; 200];

        let asset_entry = AssetEntry {
            asset_id: 1,
            asset_name: "test_sound".to_string(),
            bank_type: BankType::SOUNDS,
            offset: 0,
            size: data.len() as u64,
            decoded_size: data.len() as u64,
            codec: AssetCodec::None,
            metadata: serde_json::json!({
                "sample_rate": 44100,
                "channels": 1
            }),
        };

        let am = AssetManager::new(
            vec![asset_entry],
            AssetsPayloadSource::from_bytes(data),
            gfx_installer,
            sound_installer,
            scene_installer,
        );
        let handle = am.load(1, 0).expect("Should start loading");

        let start = Instant::now();
        while am.status(handle) != LoadStatus::READY && start.elapsed().as_secs() < 5 {
            thread::sleep(std::time::Duration::from_millis(10));
        }

        assert_eq!(am.status(handle), LoadStatus::READY);

        am.commit(handle);
        am.apply_commits();

        assert_eq!(am.status(handle), LoadStatus::COMMITTED);
        assert!(banks.sound_bank_slot(0).is_some());
    }

    #[test]
    fn test_preload_on_init() {
        let banks = Arc::new(MemoryBanks::new());
        let gfx_installer = Arc::clone(&banks) as Arc<dyn GlyphBankPoolInstaller>;
        let sound_installer = Arc::clone(&banks) as Arc<dyn SoundBankPoolInstaller>;
        let scene_installer = Arc::clone(&banks) as Arc<dyn SceneBankPoolInstaller>;

        let data = vec![0u8; 200];

        let asset_entry = AssetEntry {
            asset_id: 2,
            asset_name: "preload_sound".to_string(),
            bank_type: BankType::SOUNDS,
            offset: 0,
            size: data.len() as u64,
            decoded_size: data.len() as u64,
            codec: AssetCodec::None,
            metadata: serde_json::json!({
                "sample_rate": 44100,
                "channels": 1
            }),
        };

        let preload = vec![PreloadEntry { asset_id: 2, slot: 5 }];

        let am = AssetManager::new(
            vec![],
            AssetsPayloadSource::empty(),
            gfx_installer,
            sound_installer,
            scene_installer,
        );

        // Before init, slot 5 is empty
        assert!(banks.sound_bank_slot(5).is_none());

        am.initialize_for_cartridge(
            vec![asset_entry],
            preload,
            AssetsPayloadSource::from_bytes(data),
        );

        // After init, slot 5 should be occupied because of preload
        assert!(banks.sound_bank_slot(5).is_some());
        assert_eq!(am.slot_info(SlotRef::audio(5)).asset_id, Some(2));
    }

    #[test]
    fn test_scene_asset_loading() {
        let banks = Arc::new(MemoryBanks::new());
        let gfx_installer = Arc::clone(&banks) as Arc<dyn GlyphBankPoolInstaller>;
        let sound_installer = Arc::clone(&banks) as Arc<dyn SoundBankPoolInstaller>;
        let scene_installer = Arc::clone(&banks) as Arc<dyn SceneBankPoolInstaller>;

        let scene = test_scene();
        let data = encode_scene_payload(&scene);
        let asset_entry = test_scene_asset_entry("test_scene", &data, &scene);

        let am = AssetManager::new(
            vec![asset_entry],
            AssetsPayloadSource::from_bytes(data),
            gfx_installer,
            sound_installer,
            scene_installer,
        );
        let handle = am.load(2, 0).expect("Should start loading scene");

        let start = Instant::now();
        while am.status(handle) != LoadStatus::READY && start.elapsed().as_secs() < 5 {
            thread::sleep(std::time::Duration::from_millis(10));
        }

        assert_eq!(am.status(handle), LoadStatus::READY);
        am.commit(handle);
        am.apply_commits();

        assert_eq!(am.status(handle), LoadStatus::COMMITTED);
        assert!(banks.scene_bank_slot(0).is_some());
    }

    #[test]
    fn test_scene_preload_on_init() {
        let banks = Arc::new(MemoryBanks::new());
        let gfx_installer = Arc::clone(&banks) as Arc<dyn GlyphBankPoolInstaller>;
        let sound_installer = Arc::clone(&banks) as Arc<dyn SoundBankPoolInstaller>;
        let scene_installer = Arc::clone(&banks) as Arc<dyn SceneBankPoolInstaller>;

        let scene = test_scene();
        let data = encode_scene_payload(&scene);
        let asset_entry = test_scene_asset_entry("preload_scene", &data, &scene);
        let preload = vec![PreloadEntry { asset_id: 2, slot: 4 }];

        let am = AssetManager::new(
            vec![],
            AssetsPayloadSource::empty(),
            gfx_installer,
            sound_installer,
            scene_installer,
        );

        assert!(banks.scene_bank_slot(4).is_none());
        am.initialize_for_cartridge(
            vec![asset_entry],
            preload,
            AssetsPayloadSource::from_bytes(data),
        );

        assert!(banks.scene_bank_slot(4).is_some());
        assert_eq!(am.slot_info(SlotRef::scene(4)).asset_id, Some(2));
    }

    #[test]
    fn test_load_returns_asset_not_found() {
        let banks = Arc::new(MemoryBanks::new());
        let gfx_installer = Arc::clone(&banks) as Arc<dyn GlyphBankPoolInstaller>;
        let sound_installer = Arc::clone(&banks) as Arc<dyn SoundBankPoolInstaller>;
        let scene_installer = Arc::clone(&banks) as Arc<dyn SceneBankPoolInstaller>;
        let am = AssetManager::new(
            vec![],
            AssetsPayloadSource::empty(),
            gfx_installer,
            sound_installer,
            scene_installer,
        );

        let result = am.load(999, 0);

        assert_eq!(result, Err(AssetLoadError::AssetNotFound));
    }

    #[test]
    fn test_load_returns_slot_index_invalid() {
        let banks = Arc::new(MemoryBanks::new());
        let gfx_installer = Arc::clone(&banks) as Arc<dyn GlyphBankPoolInstaller>;
        let sound_installer = Arc::clone(&banks) as Arc<dyn SoundBankPoolInstaller>;
        let scene_installer = Arc::clone(&banks) as Arc<dyn SceneBankPoolInstaller>;
        let data = test_glyph_asset_data();
        let am = AssetManager::new(
            vec![test_glyph_asset_entry("test_glyphs", 16, 16)],
            AssetsPayloadSource::from_bytes(data),
            gfx_installer,
            sound_installer,
            scene_installer,
        );

        let result = am.load(0, 16);

        assert_eq!(result, Err(AssetLoadError::SlotIndexInvalid));
    }

    #[test]
    fn test_status_returns_unknown_handle() {
        let banks = Arc::new(MemoryBanks::new());
        let gfx_installer = Arc::clone(&banks) as Arc<dyn GlyphBankPoolInstaller>;
        let sound_installer = Arc::clone(&banks) as Arc<dyn SoundBankPoolInstaller>;
        let scene_installer = Arc::clone(&banks) as Arc<dyn SceneBankPoolInstaller>;
        let am = AssetManager::new(
            vec![],
            AssetsPayloadSource::empty(),
            gfx_installer,
            sound_installer,
            scene_installer,
        );

        assert_eq!(am.status(999), LoadStatus::UnknownHandle);
    }

    #[test]
    fn test_commit_and_cancel_return_explicit_statuses() {
        let banks = Arc::new(MemoryBanks::new());
        let gfx_installer = Arc::clone(&banks) as Arc<dyn GlyphBankPoolInstaller>;
        let sound_installer = Arc::clone(&banks) as Arc<dyn SoundBankPoolInstaller>;
        let scene_installer = Arc::clone(&banks) as Arc<dyn SceneBankPoolInstaller>;
        let data = test_glyph_asset_data();
        let am = AssetManager::new(
            vec![test_glyph_asset_entry("test_glyphs", 16, 16)],
            AssetsPayloadSource::from_bytes(data),
            gfx_installer,
            sound_installer,
            scene_installer,
        );

        assert_eq!(am.commit(999), AssetOpStatus::UnknownHandle);
        assert_eq!(am.cancel(999), AssetOpStatus::UnknownHandle);

        let handle = am.load(0, 0).expect("load must allocate handle");
        let start = Instant::now();
        while am.status(handle) != LoadStatus::READY && start.elapsed().as_secs() < 5 {
            thread::sleep(std::time::Duration::from_millis(10));
        }

        assert_eq!(am.cancel(handle), AssetOpStatus::Ok);
        assert_eq!(am.status(handle), LoadStatus::CANCELED);
        assert_eq!(am.commit(handle), AssetOpStatus::InvalidState);
    }

    #[test]
    fn test_asset_telemetry_incremental() {
        let banks = Arc::new(MemoryBanks::new());
        let gfx_installer = Arc::clone(&banks) as Arc<dyn GlyphBankPoolInstaller>;
        let sound_installer = Arc::clone(&banks) as Arc<dyn SoundBankPoolInstaller>;
        let scene_installer = Arc::clone(&banks) as Arc<dyn SceneBankPoolInstaller>;

        let width = 16;
        let height = 16;
        let data = test_glyph_asset_data();

        let am = AssetManager::new(
            vec![test_glyph_asset_entry("test_glyphs", width, height)],
            AssetsPayloadSource::from_bytes(data),
            gfx_installer,
            sound_installer,
            scene_installer,
        );

        // Initially zero
        let info = am.bank_telemetry();
        assert_eq!(info[0].bank_type, BankType::GLYPH);
        assert_eq!(info[0].used_slots, 0);
        assert_eq!(info[0].total_slots, 16);

        // Loading
        let handle = am.load(0, 0).expect("load must allocate handle");

        // While LOADING or READY, it should be in inflight_bytes
        let start = Instant::now();
        while am.status(handle) != LoadStatus::READY && start.elapsed().as_secs() < 5 {
            thread::sleep(std::time::Duration::from_millis(10));
        }

        let info = am.bank_telemetry();
        assert_eq!(info[0].used_slots, 0);

        // Commit
        am.commit(handle);
        am.apply_commits();

        let info = am.bank_telemetry();
        assert_eq!(info[0].used_slots, 1);
        assert_eq!(info[1].bank_type, BankType::SOUNDS);
        assert_eq!(info[1].used_slots, 0);

        // Shutdown resets
        am.shutdown();
        let info = am.bank_telemetry();
        assert_eq!(info[0].used_slots, 0);
    }
}