fix(coverage): restore specialized domain ownership and floors
This commit is contained in:
@@ -28,10 +28,10 @@ LLVM lines still need an owner.
|
||||
| --- | --- |
|
||||
| system/os | OS facades, process and task services |
|
||||
| system/runtime | System-side VM lifecycle, scheduling and render integration |
|
||||
| system/fs | Runtime filesystem and memcard service |
|
||||
| system/fs | Runtime filesystem, memcard.rs and the complete memcard/ module tree |
|
||||
| system/programs | Resident system programs |
|
||||
| system/core | Remaining system sources, excluding the four specialized owners |
|
||||
| asset/bank | Existing asset, cartridge and asset-driver prefixes |
|
||||
| asset/bank | HAL asset/cartridge prefixes, driver asset.rs and the complete driver asset/ module tree |
|
||||
| firmware | Firmware state and transitions |
|
||||
| host-dependent | Desktop host |
|
||||
| host/headless | Headless host and automation implementation |
|
||||
@@ -43,6 +43,10 @@ LLVM lines still need an owner.
|
||||
| dev/test-support | Shared test-program construction and development infrastructure source stubs |
|
||||
|
||||
Existing specialized paths retain their original ownership.
|
||||
Both module entry files and sibling module directories need explicit prefixes.
|
||||
Memcard and asset-driver descendants, including future nested modules, retain
|
||||
their specialized owner even when absent from the coverage report or reporting
|
||||
zero executable lines. The corresponding residual exclusions cover both forms.
|
||||
Residual domains use broad crate source prefixes with explicit exclusions,
|
||||
so a new module inherits the appropriate owner. A new crate or conflicting
|
||||
prefix must be assigned before the ownership audit can pass.
|
||||
@@ -60,6 +64,10 @@ Quality tests remain in prometeu-quality-checks/tests. They enforce the map
|
||||
and drive the auditor/helper with independent source/report fixtures,
|
||||
including omitted/overlapping owners, exclusions, absolute/relative filenames,
|
||||
absent/empty evidence, invalid statistics and percentage regression.
|
||||
Expected-owner tests use the auditor's ownership function for entry files,
|
||||
every existing descendant and future nested paths. Synthetic reports also
|
||||
check absent and zero-line descendants. Exclusive residual fallback is not
|
||||
sufficient: it can silently transfer specialized code into the wrong gate.
|
||||
The empty quality/layer library stubs inherit infrastructure ownership;
|
||||
they do not create separate gates with zero executable lines.
|
||||
|
||||
@@ -93,13 +101,16 @@ this percentage is at least baseline_percent. Counts for functions and
|
||||
regions remain supporting evidence. Scenario/contract assertions continue
|
||||
to govern behavior; a percentage does not replace them.
|
||||
|
||||
Measured coverage and the acceptance floor are separate values. This explicitly
|
||||
reviewed revision gives every domain at least 5.00 percentage points of headroom
|
||||
from the recorded local measurement. Its rule is
|
||||
Measured coverage and the acceptance floor are separate values. The historical
|
||||
margin revision gave every domain at least 5.00 percentage points of headroom
|
||||
from that recorded local measurement. Its rule was
|
||||
`new_floor = min(original_floor, measured_percent - 5.00)`, using the same
|
||||
downward truncation. Floors already providing that margin remain unchanged.
|
||||
Five percentage points means an 88.56% measurement permits an 83.56% floor;
|
||||
it is not a relative five-percent reduction.
|
||||
That historical margin is not a guarantee about later measurements or corrected
|
||||
ownership. The current map restores the reviewed system/core floor of 87.71%
|
||||
and preserves every other floor.
|
||||
|
||||
Floors remain fixed during CI. A failing run does not automatically lower them.
|
||||
An intentional scope or floor revision requires explicit review with fresh
|
||||
@@ -153,14 +164,14 @@ on macOS/aarch64:
|
||||
|
||||
These are historical starting floors; current acceptance floors appear below.
|
||||
|
||||
## Current local margins
|
||||
## Historical margin revision
|
||||
|
||||
The [margin evidence](COVERAGE_DOMAINS_MARGIN.json) records fresh measurements,
|
||||
original and revised floors, toolchain, fingerprints and executed validation.
|
||||
Only domains with less than 5.00 percentage points of headroom were adjusted.
|
||||
The historical evidence above remains unchanged.
|
||||
|
||||
| Domain | Measured lines | Original floor | Current floor | Margin (points) |
|
||||
| Domain | Measured lines | Original floor | Revised floor | Margin (points) |
|
||||
| --- | ---: | ---: | ---: | ---: |
|
||||
| system/os | 82.24% | 77.24% | 77.24% | 5.00 |
|
||||
| system/runtime | 81.19% | 76.50% | 76.19% | 5.00 |
|
||||
@@ -183,6 +194,43 @@ The full local `make ci-domains` validation passed with 939 tests passed and
|
||||
in verification; its final floor uses the lower measurement. All gates were
|
||||
rechecked against the verification report after that final adjustment.
|
||||
|
||||
## Current local measurement
|
||||
|
||||
The [current evidence](COVERAGE_DOMAINS_CURRENT.json) records the repaired
|
||||
module-tree ownership, fixed floors, normalized source paths, actual line
|
||||
counts and source/config/report fingerprints. Both historical JSON records
|
||||
above remain unchanged. The measurement uses the implementation working tree
|
||||
identified by its base HEAD and content fingerprints.
|
||||
|
||||
| Domain | Covered / total lines | Measured lines | Fixed floor | Margin (points) |
|
||||
| --- | ---: | ---: | ---: | ---: |
|
||||
| system/os | 1410 / 1711 | 82.40% | 77.24% | 5.16 |
|
||||
| system/runtime | 2762 / 3309 | 83.46% | 76.19% | 7.27 |
|
||||
| system/fs | 1944 / 2469 | 78.73% | 76.08% | 2.65 |
|
||||
| system/programs | 556 / 567 | 98.05% | 93.05% | 5.00 |
|
||||
| asset/bank | 3096 / 3420 | 90.52% | 86.76% | 3.76 |
|
||||
| firmware | 1990 / 2314 | 85.99% | 83.20% | 2.79 |
|
||||
| host-dependent | 1196 / 2059 | 58.08% | 40.05% | 18.03 |
|
||||
| host/headless | 739 / 855 | 86.43% | 83.39% | 3.04 |
|
||||
| vm/core | 8308 / 9294 | 89.39% | 84.29% | 5.10 |
|
||||
| bytecode | 3085 / 3303 | 93.39% | 88.26% | 5.13 |
|
||||
| hal/core | 2093 / 2369 | 88.34% | 83.56% | 4.78 |
|
||||
| drivers/core | 2728 / 3059 | 89.17% | 79.51% | 9.66 |
|
||||
| system/core | 1353 / 1444 | 93.69% | 87.71% | 5.98 |
|
||||
| tooling | 396 / 612 | 64.70% | 59.75% | 4.95 |
|
||||
| dev/test-support | 99 / 115 | 86.08% | 80.96% | 5.12 |
|
||||
|
||||
The fresh macOS/aarch64 `make ci-domains` run passed all 15 coverage gates
|
||||
with 1,021 tests passed and 11 ignored. The 10 focused ownership/evidence
|
||||
tests and strict package Clippy also passed. No floor reduction or additional
|
||||
runtime behavior test was needed to pass the repaired map.
|
||||
|
||||
The current Makefile target still uses non-strict workspace Clippy. A separate
|
||||
`cargo clippy --workspace --all-targets --all-features -- -D warnings` run failed
|
||||
on existing VM `useless_vec`, `cloned_ref_to_slice_refs` and
|
||||
`items_after_test_module` diagnostics. This evidence certifies the corrected
|
||||
coverage map and its gates; full strict workspace qualification remains pending.
|
||||
|
||||
Platform-specific compilation and host scenarios can change report totals.
|
||||
Local evidence does not certify an unexecuted Linux or Intel Mac run; evaluate
|
||||
those runs against the configured floors and investigate differences.
|
||||
|
||||
Reference in New Issue
Block a user