diff --git a/crates/console/prometeu-system/src/os/facades/sessions.rs b/crates/console/prometeu-system/src/os/facades/sessions.rs index 459194d7..d9a89ef2 100644 --- a/crates/console/prometeu-system/src/os/facades/sessions.rs +++ b/crates/console/prometeu-system/src/os/facades/sessions.rs @@ -2,6 +2,7 @@ use crate::os::LifecycleError; use crate::os::SystemOS; use crate::task::TaskId; use crate::vm_session::{VmSession, VmSessionError}; +use std::sync::Arc; pub struct SessionsFacade<'a> { pub(in crate::os) os: &'a mut SystemOS, @@ -62,6 +63,10 @@ impl<'a> SessionsFacade<'a> { self.os.vm_sessions.for_task(task_id) } + pub fn vm_session_for_task_mut(&mut self, task_id: TaskId) -> Option<&mut VmSession> { + self.os.vm_sessions.for_task_mut(task_id) + } + pub fn resident_game_session_for_app(&self, app_id: u32) -> Option<&VmSession> { self.os.vm_sessions.resident_game_for_app(app_id) } @@ -79,6 +84,11 @@ impl<'a> SessionsFacade<'a> { .expect("session process should exist") .clone(); - self.os.vm_sessions.create_for_task(&task, &process, "").map(|_| ()) + let cap_config = self.os.vm_runtime.certifier.config; + let logs_count = Arc::clone(&self.os.log_service.logs_count); + self.os + .vm_sessions + .create_for_task(&task, &process, "", Some(cap_config), logs_count) + .map(|_| ()) } } diff --git a/crates/console/prometeu-system/src/os/system_os.rs b/crates/console/prometeu-system/src/os/system_os.rs index 2398f2a7..09bb980c 100644 --- a/crates/console/prometeu-system/src/os/system_os.rs +++ b/crates/console/prometeu-system/src/os/system_os.rs @@ -259,6 +259,42 @@ mod tests { assert_eq!(sessions.vm_session_count(), 1); } + #[test] + fn vm_sessions_hold_independent_runtime_state() { + let mut os = SystemOS::new(None); + let game = os.sessions().create_vm_game_task(42, "Sector Crawl"); + os.lifecycle().request_home_from_game(game).expect("home request should succeed"); + os.lifecycle().advance_game_pause_budget(game).expect("budget should expire"); + let shell = os.sessions().create_vm_shell_task(7, "Settings"); + + { + let mut sessions = os.sessions(); + let game_session = + sessions.vm_session_for_task_mut(game).expect("game VM session should exist"); + game_session.runtime.tick_index = 100; + game_session.open_files.insert(1, "/game.dat".to_string()); + } + + { + let mut sessions = os.sessions(); + let shell_session = + sessions.vm_session_for_task_mut(shell).expect("shell VM session should exist"); + shell_session.runtime.tick_index = 5; + shell_session.open_files.insert(1, "/shell.dat".to_string()); + } + + let sessions = os.sessions(); + let game_session = + sessions.vm_session_for_task(game).expect("game VM session should exist"); + let shell_session = + sessions.vm_session_for_task(shell).expect("shell VM session should exist"); + + assert_eq!(game_session.runtime.tick_index, 100); + assert_eq!(shell_session.runtime.tick_index, 5); + assert_eq!(game_session.open_files.get(&1).map(String::as_str), Some("/game.dat")); + assert_eq!(shell_session.open_files.get(&1).map(String::as_str), Some("/shell.dat")); + } + #[test] fn home_request_notifies_game_before_budget_suspends_it() { let mut os = SystemOS::new(None); diff --git a/crates/console/prometeu-system/src/services/vm_session.rs b/crates/console/prometeu-system/src/services/vm_session.rs index fac91798..88a005ef 100644 --- a/crates/console/prometeu-system/src/services/vm_session.rs +++ b/crates/console/prometeu-system/src/services/vm_session.rs @@ -1,8 +1,13 @@ +use crate::VirtualMachineRuntime; +use crate::fs::FsState; use crate::process::{Process, ProcessId, ProcessKind}; use crate::task::{Task, TaskId, TaskKind}; use prometeu_hal::app_mode::AppMode; +use prometeu_hal::telemetry::CertificationConfig; use prometeu_vm::VirtualMachine; use std::collections::HashMap; +use std::sync::Arc; +use std::sync::atomic::AtomicU32; #[derive(Debug, Clone, Copy, PartialEq, Eq, Hash)] pub struct VmSessionId(pub TaskId); @@ -24,6 +29,10 @@ pub struct VmSession { pub app_version: String, pub app_mode: AppMode, pub vm: VirtualMachine, + pub runtime: VirtualMachineRuntime, + pub fs_state: FsState, + pub open_files: HashMap, + pub next_handle: u32, } impl VmSession { @@ -32,6 +41,8 @@ impl VmSession { process: &Process, app_mode: AppMode, app_version: impl Into, + cap_config: Option, + logs_count: Arc, ) -> Self { Self { id: VmSessionId(task.id), @@ -42,8 +53,17 @@ impl VmSession { app_version: app_version.into(), app_mode, vm: VirtualMachine::default(), + runtime: VirtualMachineRuntime::new_with_log_counter(cap_config, logs_count), + fs_state: FsState::Unmounted, + open_files: HashMap::new(), + next_handle: 1, } } + + pub fn clear_cartridge_service_state(&mut self) { + self.open_files.clear(); + self.next_handle = 1; + } } #[derive(Default)] @@ -61,6 +81,8 @@ impl VmSessionRegistry { task: &Task, process: &Process, app_version: impl Into, + cap_config: Option, + logs_count: Arc, ) -> Result { if task.process_id != process.id { return Err(VmSessionError::TaskProcessMismatch { @@ -76,7 +98,10 @@ impl VmSessionRegistry { return Err(VmSessionError::SessionAlreadyExists(task.id)); } - self.sessions.insert(id, VmSession::new(task, process, app_mode, app_version)); + self.sessions.insert( + id, + VmSession::new(task, process, app_mode, app_version, cap_config, logs_count), + ); Ok(id) } @@ -143,7 +168,9 @@ mod tests { let task = Task::new(TaskId(7), process.id, 42, "Stress", TaskKind::Game); let mut registry = VmSessionRegistry::new(); - let id = registry.create_for_task(&task, &process, "").expect("session should create"); + let id = registry + .create_for_task(&task, &process, "", None, Arc::new(AtomicU32::new(0))) + .expect("session should create"); let session = registry.get(id).expect("session should exist"); assert_eq!(session.id, VmSessionId(task.id)); @@ -152,6 +179,9 @@ mod tests { assert_eq!(session.app_id, 42); assert_eq!(session.title, "Stress"); assert_eq!(session.app_mode, AppMode::Game); + assert_eq!(session.runtime.current_app_id, 0); + assert_eq!(session.fs_state, FsState::Unmounted); + assert_eq!(session.next_handle, 1); } #[test] @@ -160,7 +190,9 @@ mod tests { let task = Task::new(TaskId(3), process.id, 7, "Shell", TaskKind::Shell); let mut registry = VmSessionRegistry::new(); - let id = registry.create_for_task(&task, &process, "1.0").expect("session should create"); + let id = registry + .create_for_task(&task, &process, "1.0", None, Arc::new(AtomicU32::new(0))) + .expect("session should create"); let session = registry.get(id).expect("session should exist"); assert_eq!(session.app_mode, AppMode::Shell); @@ -174,7 +206,7 @@ mod tests { let mut registry = VmSessionRegistry::new(); assert_eq!( - registry.create_for_task(&task, &process, ""), + registry.create_for_task(&task, &process, "", None, Arc::new(AtomicU32::new(0))), Err(VmSessionError::ProcessIsNotVmBacked(process.id)) ); } @@ -184,7 +216,9 @@ mod tests { let process = Process::new(ProcessId(1), 42, "Stress", ProcessKind::VmGame); let task = Task::new(TaskId(7), process.id, 42, "Stress", TaskKind::Game); let mut registry = VmSessionRegistry::new(); - registry.create_for_task(&task, &process, "").expect("session should create"); + registry + .create_for_task(&task, &process, "", None, Arc::new(AtomicU32::new(0))) + .expect("session should create"); assert_eq!( registry.resident_game_for_app(42).map(|session| session.task_id), @@ -192,4 +226,52 @@ mod tests { ); assert_eq!(registry.resident_game_for_app(43).map(|session| session.task_id), None); } + + #[test] + fn session_runtime_state_is_independent_per_session() { + let game_process = Process::new(ProcessId(1), 42, "Stress", ProcessKind::VmGame); + let game_task = Task::new(TaskId(7), game_process.id, 42, "Stress", TaskKind::Game); + let shell_process = Process::new(ProcessId(2), 9, "Shell", ProcessKind::VmShell); + let shell_task = Task::new(TaskId(8), shell_process.id, 9, "Shell", TaskKind::Shell); + let mut registry = VmSessionRegistry::new(); + + registry + .create_for_task(&game_task, &game_process, "", None, Arc::new(AtomicU32::new(0))) + .expect("game session should create"); + registry + .create_for_task(&shell_task, &shell_process, "", None, Arc::new(AtomicU32::new(0))) + .expect("shell session should create"); + + registry + .for_task_mut(game_task.id) + .expect("game session should exist") + .runtime + .tick_index = 11; + registry + .for_task_mut(shell_task.id) + .expect("shell session should exist") + .runtime + .tick_index = 3; + registry + .for_task_mut(game_task.id) + .expect("game session should exist") + .open_files + .insert(1, "/game.save".to_string()); + + assert_eq!( + registry.for_task(game_task.id).map(|session| session.runtime.tick_index), + Some(11) + ); + assert_eq!( + registry.for_task(shell_task.id).map(|session| session.runtime.tick_index), + Some(3) + ); + assert!( + registry + .for_task(shell_task.id) + .expect("shell session should exist") + .open_files + .is_empty() + ); + } } diff --git a/discussion/index.ndjson b/discussion/index.ndjson index 23009172..50954d72 100644 --- a/discussion/index.ndjson +++ b/discussion/index.ndjson @@ -2,7 +2,7 @@ {"type":"discussion","id":"DSC-0043","status":"open","ticket":"system-os-cartridge-switch-orchestrator","title":"SystemOS Cartridge Switch Orchestrator","created_at":"2026-07-03","updated_at":"2026-07-03","tags":["runtime","os","lifecycle","game","cartridge","architecture"],"agendas":[{"id":"AGD-0044","file":"AGD-0044-systemos-cartridge-switch-orchestrator.md","status":"open","created_at":"2026-07-03","updated_at":"2026-07-03"}],"decisions":[],"plans":[],"lessons":[]} {"type":"discussion","id":"DSC-0039","status":"abandoned","ticket":"render-pipeline-family-and-future-3d","title":"Render Pipeline Family and Future 3D","created_at":"2026-06-04","updated_at":"2026-06-04","tags":["gfx","renderer","runtime","architecture","pipeline"],"agendas":[{"id":"AGD-0039","file":"AGD-0039-render-pipeline-family-and-future-3d.md","status":"abandoned","created_at":"2026-06-04","updated_at":"2026-06-04","_override_reason":"User explicitly chose to close this agenda without a new decision because DSC-0038 already established enough architecture for future extension, and 3D is intentionally deferred."}],"decisions":[],"plans":[],"lessons":[],"_override_reason":"User explicitly chose to close this agenda without a new decision because DSC-0038 already established enough architecture for future extension, and 3D is intentionally deferred."} {"type":"discussion","id":"DSC-0040","status":"done","ticket":"vm-render-parallel-execution-boundary","title":"VM and Render Parallel Execution Boundary","created_at":"2026-06-04","updated_at":"2026-06-06","tags":["runtime","renderer","vm","concurrency","architecture","perf"],"agendas":[],"decisions":[],"plans":[],"lessons":[{"id":"LSN-0048","file":"discussion/lessons/DSC-0040-vm-render-parallel-execution-boundary/LSN-0048-render-workers-need-a-closed-packet-contract.md","status":"done","created_at":"2026-06-06","updated_at":"2026-06-06"}]} -{"type":"discussion","id":"DSC-0041","status":"in_progress","ticket":"foreground-stack-game-pause-shell-vm-backed","title":"Foreground Stack, Game Pause, and VM-Backed Shell Coexistence","created_at":"2026-06-05","updated_at":"2026-07-04","tags":["runtime","os","lifecycle","shell","game","vm","foreground","architecture"],"agendas":[{"id":"AGD-0041","file":"AGD-0041-foreground-stack-game-pause-shell-vm-backed.md","status":"accepted","created_at":"2026-06-05","updated_at":"2026-07-03"},{"id":"AGD-0046","file":"AGD-0046-vm-context-ownership-for-resident-game-and-vm-backed-shell.md","status":"accepted","created_at":"2026-07-04","updated_at":"2026-07-04"}],"decisions":[{"id":"DEC-0037","file":"DEC-0037-foreground-stack-and-game-pause-contract.md","status":"accepted","created_at":"2026-07-03","updated_at":"2026-07-03","ref_agenda":"AGD-0041"},{"id":"DEC-0038","file":"DEC-0038-vm-session-ownership-for-vm-backed-processes.md","status":"accepted","created_at":"2026-07-04","updated_at":"2026-07-04","ref_agenda":"AGD-0046"}],"plans":[{"id":"PLN-0136","file":"PLN-0136-route-desktop-home-key-outside-guest-input.md","status":"done","created_at":"2026-07-03","updated_at":"2026-07-03","ref_decisions":["DEC-0037"]},{"id":"PLN-0137","file":"PLN-0137-implement-systemos-foreground-stack-state.md","status":"done","created_at":"2026-07-03","updated_at":"2026-07-03","ref_decisions":["DEC-0037"]},{"id":"PLN-0138","file":"PLN-0138-specify-foreground-pause-and-home-contract.md","status":"done","created_at":"2026-07-03","updated_at":"2026-07-03","ref_decisions":["DEC-0037"]},{"id":"PLN-0139","file":"PLN-0139-validate-game-home-shell-game-end-to-end.md","status":"done","created_at":"2026-07-03","updated_at":"2026-07-03","ref_decisions":["DEC-0037"]},{"id":"PLN-0140","file":"PLN-0140-deliver-game-pause-resume-and-suspension.md","status":"done","created_at":"2026-07-03","updated_at":"2026-07-03","ref_decisions":["DEC-0037"]},{"id":"PLN-0141","file":"PLN-0141-integrate-render-audio-and-input-pause-boundaries.md","status":"done","created_at":"2026-07-03","updated_at":"2026-07-03","ref_decisions":["DEC-0037"]},{"id":"PLN-0142","file":"PLN-0142-deliver-game-lifecycle-events-to-vm-runtime.md","status":"done","created_at":"2026-07-04","updated_at":"2026-07-04","ref_decisions":["DEC-0037"]},{"id":"PLN-0143","file":"PLN-0143-guarantee-cooperative-pause-budget-tick-before-suspension.md","status":"done","created_at":"2026-07-04","updated_at":"2026-07-04","ref_decisions":["DEC-0037"]},{"id":"PLN-0144","file":"PLN-0144-suspend-resident-game-when-shell-takes-foreground.md","status":"done","created_at":"2026-07-04","updated_at":"2026-07-04","ref_decisions":["DEC-0037"]},{"id":"PLN-0145","file":"PLN-0145-centralize-resident-game-resume-transition.md","status":"done","created_at":"2026-07-04","updated_at":"2026-07-04","ref_decisions":["DEC-0037"]},{"id":"PLN-0146","file":"PLN-0146-consolidate-lifecycle-process-lookup-helpers.md","status":"done","created_at":"2026-07-04","updated_at":"2026-07-04","ref_decisions":["DEC-0037"]},{"id":"PLN-0147","file":"PLN-0147-move-native-shell-profile-update-into-hub.md","status":"done","created_at":"2026-07-04","updated_at":"2026-07-04","ref_decisions":["DEC-0037"]},{"id":"PLN-0148","file":"PLN-0148-introduce-vm-session-registry-and-identity.md","status":"done","created_at":"2026-07-04","updated_at":"2026-07-04","ref_decisions":["DEC-0038"]},{"id":"PLN-0149","file":"PLN-0149-move-vm-runtime-state-into-vm-sessions.md","status":"open","created_at":"2026-07-04","updated_at":"2026-07-04","ref_decisions":["DEC-0038"]},{"id":"PLN-0150","file":"PLN-0150-route-cartridge-loading-through-vm-sessions.md","status":"open","created_at":"2026-07-04","updated_at":"2026-07-04","ref_decisions":["DEC-0038"]},{"id":"PLN-0151","file":"PLN-0151-schedule-foreground-vm-session-ticks.md","status":"open","created_at":"2026-07-04","updated_at":"2026-07-04","ref_decisions":["DEC-0038"]},{"id":"PLN-0152","file":"PLN-0152-validate-game-and-vm-shell-session-coexistence.md","status":"open","created_at":"2026-07-04","updated_at":"2026-07-04","ref_decisions":["DEC-0038"]},{"id":"PLN-0153","file":"PLN-0153-specify-vm-session-ownership-and-background-ready-scheduling.md","status":"open","created_at":"2026-07-04","updated_at":"2026-07-04","ref_decisions":["DEC-0038"]}],"lessons":[]} +{"type":"discussion","id":"DSC-0041","status":"in_progress","ticket":"foreground-stack-game-pause-shell-vm-backed","title":"Foreground Stack, Game Pause, and VM-Backed Shell Coexistence","created_at":"2026-06-05","updated_at":"2026-07-04","tags":["runtime","os","lifecycle","shell","game","vm","foreground","architecture"],"agendas":[{"id":"AGD-0041","file":"AGD-0041-foreground-stack-game-pause-shell-vm-backed.md","status":"accepted","created_at":"2026-06-05","updated_at":"2026-07-03"},{"id":"AGD-0046","file":"AGD-0046-vm-context-ownership-for-resident-game-and-vm-backed-shell.md","status":"accepted","created_at":"2026-07-04","updated_at":"2026-07-04"}],"decisions":[{"id":"DEC-0037","file":"DEC-0037-foreground-stack-and-game-pause-contract.md","status":"accepted","created_at":"2026-07-03","updated_at":"2026-07-03","ref_agenda":"AGD-0041"},{"id":"DEC-0038","file":"DEC-0038-vm-session-ownership-for-vm-backed-processes.md","status":"accepted","created_at":"2026-07-04","updated_at":"2026-07-04","ref_agenda":"AGD-0046"}],"plans":[{"id":"PLN-0136","file":"PLN-0136-route-desktop-home-key-outside-guest-input.md","status":"done","created_at":"2026-07-03","updated_at":"2026-07-03","ref_decisions":["DEC-0037"]},{"id":"PLN-0137","file":"PLN-0137-implement-systemos-foreground-stack-state.md","status":"done","created_at":"2026-07-03","updated_at":"2026-07-03","ref_decisions":["DEC-0037"]},{"id":"PLN-0138","file":"PLN-0138-specify-foreground-pause-and-home-contract.md","status":"done","created_at":"2026-07-03","updated_at":"2026-07-03","ref_decisions":["DEC-0037"]},{"id":"PLN-0139","file":"PLN-0139-validate-game-home-shell-game-end-to-end.md","status":"done","created_at":"2026-07-03","updated_at":"2026-07-03","ref_decisions":["DEC-0037"]},{"id":"PLN-0140","file":"PLN-0140-deliver-game-pause-resume-and-suspension.md","status":"done","created_at":"2026-07-03","updated_at":"2026-07-03","ref_decisions":["DEC-0037"]},{"id":"PLN-0141","file":"PLN-0141-integrate-render-audio-and-input-pause-boundaries.md","status":"done","created_at":"2026-07-03","updated_at":"2026-07-03","ref_decisions":["DEC-0037"]},{"id":"PLN-0142","file":"PLN-0142-deliver-game-lifecycle-events-to-vm-runtime.md","status":"done","created_at":"2026-07-04","updated_at":"2026-07-04","ref_decisions":["DEC-0037"]},{"id":"PLN-0143","file":"PLN-0143-guarantee-cooperative-pause-budget-tick-before-suspension.md","status":"done","created_at":"2026-07-04","updated_at":"2026-07-04","ref_decisions":["DEC-0037"]},{"id":"PLN-0144","file":"PLN-0144-suspend-resident-game-when-shell-takes-foreground.md","status":"done","created_at":"2026-07-04","updated_at":"2026-07-04","ref_decisions":["DEC-0037"]},{"id":"PLN-0145","file":"PLN-0145-centralize-resident-game-resume-transition.md","status":"done","created_at":"2026-07-04","updated_at":"2026-07-04","ref_decisions":["DEC-0037"]},{"id":"PLN-0146","file":"PLN-0146-consolidate-lifecycle-process-lookup-helpers.md","status":"done","created_at":"2026-07-04","updated_at":"2026-07-04","ref_decisions":["DEC-0037"]},{"id":"PLN-0147","file":"PLN-0147-move-native-shell-profile-update-into-hub.md","status":"done","created_at":"2026-07-04","updated_at":"2026-07-04","ref_decisions":["DEC-0037"]},{"id":"PLN-0148","file":"PLN-0148-introduce-vm-session-registry-and-identity.md","status":"done","created_at":"2026-07-04","updated_at":"2026-07-04","ref_decisions":["DEC-0038"]},{"id":"PLN-0149","file":"PLN-0149-move-vm-runtime-state-into-vm-sessions.md","status":"done","created_at":"2026-07-04","updated_at":"2026-07-04","ref_decisions":["DEC-0038"]},{"id":"PLN-0150","file":"PLN-0150-route-cartridge-loading-through-vm-sessions.md","status":"open","created_at":"2026-07-04","updated_at":"2026-07-04","ref_decisions":["DEC-0038"]},{"id":"PLN-0151","file":"PLN-0151-schedule-foreground-vm-session-ticks.md","status":"open","created_at":"2026-07-04","updated_at":"2026-07-04","ref_decisions":["DEC-0038"]},{"id":"PLN-0152","file":"PLN-0152-validate-game-and-vm-shell-session-coexistence.md","status":"open","created_at":"2026-07-04","updated_at":"2026-07-04","ref_decisions":["DEC-0038"]},{"id":"PLN-0153","file":"PLN-0153-specify-vm-session-ownership-and-background-ready-scheduling.md","status":"open","created_at":"2026-07-04","updated_at":"2026-07-04","ref_decisions":["DEC-0038"]}],"lessons":[]} {"type":"discussion","id":"DSC-0042","status":"done","ticket":"real-render-worker-establishment","title":"Real Render Worker Establishment","created_at":"2026-06-06","updated_at":"2026-06-20","tags":["runtime","renderer","worker","concurrency","host","hal","architecture"],"agendas":[],"decisions":[],"plans":[],"lessons":[{"id":"LSN-0049","file":"discussion/lessons/DSC-0042-real-render-worker-establishment/LSN-0049-render-worker-publication-boundary.md","status":"done","created_at":"2026-06-20","updated_at":"2026-06-20"}]} {"type":"discussion","id":"DSC-0038","status":"done","ticket":"render-frame-packet-boundary","title":"Logical Render Pipelines and Command Packets","created_at":"2026-05-25","updated_at":"2026-06-04","tags":["gfx","renderer","runtime","frame-composer","architecture","ui","pipeline"],"agendas":[],"decisions":[],"plans":[],"lessons":[{"id":"LSN-0047","file":"discussion/lessons/DSC-0038-render-frame-packet-boundary/LSN-0047-typed-render-submissions-preserve-domain-boundaries.md","status":"done","created_at":"2026-06-04","updated_at":"2026-06-04"}]} {"type":"discussion","id":"DSC-0035","status":"done","ticket":"task-owned-shell-windows","title":"Agenda - Task-Owned Shell Windows","created_at":"2026-05-15","updated_at":"2026-05-15","tags":["runtime","os","task","window-manager","shell","lifecycle"],"agendas":[],"decisions":[],"plans":[],"lessons":[{"id":"LSN-0044","file":"discussion/lessons/DSC-0035-task-owned-shell-windows/LSN-0044-task-window-liveness-belongs-to-the-task.md","status":"done","created_at":"2026-05-15","updated_at":"2026-05-15"}]} diff --git a/discussion/workflow/plans/PLN-0149-move-vm-runtime-state-into-vm-sessions.md b/discussion/workflow/plans/PLN-0149-move-vm-runtime-state-into-vm-sessions.md index d03b29f0..c7396a18 100644 --- a/discussion/workflow/plans/PLN-0149-move-vm-runtime-state-into-vm-sessions.md +++ b/discussion/workflow/plans/PLN-0149-move-vm-runtime-state-into-vm-sessions.md @@ -2,7 +2,7 @@ id: PLN-0149 ticket: foreground-stack-game-pause-shell-vm-backed title: Move VM Runtime State Into VM Sessions -status: open +status: done created: 2026-07-04 ref_decisions: [DEC-0038] tags: [runtime, os, lifecycle, shell, game, vm, foreground, architecture]