PR003: implement audio status-first returns for play operations

This commit is contained in:
2026-03-24 13:40:50 +00:00
parent fe6931d420
commit 998252aa25
6 changed files with 117 additions and 36 deletions
+11 -14
View File
@@ -1,4 +1,4 @@
use prometeu_hal::AudioBridge;
use prometeu_hal::{AudioBridge, AudioOpStatus};
use std::sync::Arc;
/// Maximum number of simultaneous audio voices supported by the hardware.
@@ -113,7 +113,7 @@ impl AudioBridge for Audio {
pitch: f64,
priority: u8,
loop_mode: prometeu_hal::LoopMode,
) {
) -> AudioOpStatus {
let lm = match loop_mode {
prometeu_hal::LoopMode::Off => LoopMode::Off,
prometeu_hal::LoopMode::On => LoopMode::On,
@@ -129,7 +129,7 @@ impl AudioBridge for Audio {
pitch: f64,
priority: u8,
loop_mode: prometeu_hal::LoopMode,
) {
) -> AudioOpStatus {
let lm = match loop_mode {
prometeu_hal::LoopMode::Off => LoopMode::Off,
prometeu_hal::LoopMode::On => LoopMode::On,
@@ -177,9 +177,9 @@ impl Audio {
pitch: f64,
priority: u8,
loop_mode: LoopMode,
) {
) -> AudioOpStatus {
if voice_id >= MAX_CHANNELS {
return;
return AudioOpStatus::VoiceInvalid;
}
// Resolve the sample from the hardware pools
@@ -193,14 +193,10 @@ impl Audio {
// "[Audio] Resolved sample from bank {} sample {}. Playing on voice {}.",
// bank_id, sample_id, voice_id
// );
self.play_sample(s, voice_id, volume, pan, pitch, priority, loop_mode);
self.play_sample(s, voice_id, volume, pan, pitch, priority, loop_mode)
} else {
AudioOpStatus::SampleNotFound
}
// else {
// eprintln!(
// "[Audio] Failed to resolve sample from bank {} sample {}.",
// bank_id, sample_id
// );
// }
}
#[allow(clippy::too_many_arguments)]
@@ -213,9 +209,9 @@ impl Audio {
pitch: f64,
priority: u8,
loop_mode: LoopMode,
) {
) -> AudioOpStatus {
if voice_id >= MAX_CHANNELS {
return;
return AudioOpStatus::VoiceInvalid;
}
// Update local state
@@ -240,6 +236,7 @@ impl Audio {
priority,
loop_mode,
});
AudioOpStatus::Ok
}
pub fn stop(&mut self, voice_id: usize) {