introduce gate Id and heap index
This commit is contained in:
@@ -19,53 +19,6 @@
|
||||
|
||||
---
|
||||
|
||||
# PR-01 — Linker: Relocate control-flow jump targets when concatenating modules
|
||||
|
||||
### Briefing
|
||||
|
||||
Today the linker patches `CALL` and `PUSH_CONST` immediates, but **does not relocate jump targets** (`JMP`, `JMP_IF_*`) after concatenating module bytecode into a single code blob. This breaks cross-module correctness because label resolution in per-module assembly produces addresses relative to each module’s own code segment.
|
||||
|
||||
### Target
|
||||
|
||||
* In the linker’s relocation pass, patch immediates for:
|
||||
|
||||
* `OpCode::Jmp`
|
||||
* `OpCode::JmpIfTrue`
|
||||
* `OpCode::JmpIfFalse`
|
||||
* Add `module_code_offsets[module_index]` to the jump target immediate.
|
||||
|
||||
### Non-goals
|
||||
|
||||
* No changes to opcode encoding.
|
||||
* No changes to verifier.
|
||||
* No changes to how labels are resolved in the assembler.
|
||||
|
||||
### Implementation notes
|
||||
|
||||
* Extend the existing “patch immediates” loop in `Linker::link`.
|
||||
* Determine `module_index` from the current iterated module during relocation.
|
||||
* Make sure **only jump targets** are adjusted, not fallthrough logic.
|
||||
* Add a small helper function for patching immediates to reduce duplication.
|
||||
|
||||
### Tests
|
||||
|
||||
1. **Unit test** (preferred) in `prometeu-linker` (or wherever `Linker` tests live):
|
||||
|
||||
* Create 2 small modules where module #2 contains a local jump.
|
||||
* Link them.
|
||||
* Assert that the encoded jump immediate in the final program equals `original_target + module2_offset`.
|
||||
2. **Integration test** (if a unit test is hard):
|
||||
|
||||
* Build two modules and execute in VM; ensure it reaches expected instruction sequence (e.g., sets a known local/global).
|
||||
|
||||
### Acceptance criteria
|
||||
|
||||
* Multi-module programs with jumps inside non-first modules execute correctly.
|
||||
* Existing call/const relocation remains correct.
|
||||
* Tests cover at least one `JMP` and one conditional jump.
|
||||
|
||||
---
|
||||
|
||||
## PR-02 — VM: Introduce GateId vs heap index and a minimal GatePool (no RC yet)
|
||||
|
||||
### Briefing
|
||||
|
||||
Reference in New Issue
Block a user