Make discussion state mutations concurrency-safe
This commit is contained in:
@@ -3,7 +3,10 @@ from __future__ import annotations
|
||||
import contextlib
|
||||
import io
|
||||
import json
|
||||
import os
|
||||
from pathlib import Path
|
||||
import subprocess
|
||||
import sys
|
||||
import unittest
|
||||
|
||||
from discussion_framework.cli import main
|
||||
@@ -145,6 +148,52 @@ class CliTest(unittest.TestCase):
|
||||
self.assertIn("status: accepted", decision.read_text(encoding="utf-8"))
|
||||
self.assertIn("status: done", plan.read_text(encoding="utf-8"))
|
||||
|
||||
def test_parallel_add_plan_allocates_unique_ids(self) -> None:
|
||||
with TempDir() as root:
|
||||
main(["--root", str(root), "init"])
|
||||
self.assertEqual(main(["--root", str(root), "start", "parallel-demo", "Parallel Demo"]), 0)
|
||||
self.assertEqual(main(["--root", str(root), "accept-agenda", "DSC-0001"]), 0)
|
||||
self.assertEqual(main(["--root", str(root), "add-decision", "DSC-0001", "--title", "Parallel Decision"]), 0)
|
||||
self.assertEqual(main(["--root", str(root), "accept-decision", "DSC-0001"]), 0)
|
||||
|
||||
script = "from discussion_framework.cli import main; import sys; raise SystemExit(main(sys.argv[1:]))"
|
||||
env = os.environ.copy()
|
||||
src = str(Path(__file__).resolve().parents[1] / "src")
|
||||
env["PYTHONPATH"] = src + os.pathsep + env["PYTHONPATH"] if env.get("PYTHONPATH") else src
|
||||
processes = [
|
||||
subprocess.Popen(
|
||||
[
|
||||
sys.executable,
|
||||
"-c",
|
||||
script,
|
||||
"--root",
|
||||
str(root),
|
||||
"add-plan",
|
||||
"DSC-0001",
|
||||
"--title",
|
||||
f"Parallel Plan {number}",
|
||||
],
|
||||
env=env,
|
||||
stdout=subprocess.PIPE,
|
||||
stderr=subprocess.PIPE,
|
||||
text=True,
|
||||
)
|
||||
for number in range(1, 4)
|
||||
]
|
||||
|
||||
results = [process.communicate(timeout=10) + (process.returncode,) for process in processes]
|
||||
self.assertEqual([returncode for *_streams, returncode in results], [0, 0, 0], results)
|
||||
|
||||
discussion = root / "discussion"
|
||||
records = [json.loads(line) for line in (discussion / "index.ndjson").read_text(encoding="utf-8").splitlines()]
|
||||
meta = records[0]
|
||||
plans = records[1]["plans"]
|
||||
|
||||
self.assertEqual(meta["next_id"]["PLN"], 4)
|
||||
self.assertEqual(sorted(plan["id"] for plan in plans), ["PLN-0001", "PLN-0002", "PLN-0003"])
|
||||
for plan in plans:
|
||||
self.assertTrue((discussion / "workflow" / "plans" / plan["file"]).exists())
|
||||
|
||||
def test_housekeep_with_lesson_removes_workflow_artifacts(self) -> None:
|
||||
with TempDir() as root:
|
||||
main(["--root", str(root), "init"])
|
||||
|
||||
Reference in New Issue
Block a user